-
Notifications
You must be signed in to change notification settings - Fork 14.7k
Update GZ Plugin OpticalFlow CMake configuration for library paths #25957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
src/modules/simulation/gz_plugins/optical_flow/optical_flow.cmake
Outdated
Show resolved
Hide resolved
Co-authored-by: Jacob Dahl <[email protected]>
d3752ca to
095ac0a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR improves cross-platform compatibility for the OpticalFlow Gazebo plugin by replacing hardcoded .so library extensions with the CMake variable CMAKE_SHARED_LIBRARY_SUFFIX. This allows the build system to work correctly on macOS (which uses .dylib) in addition to Linux (which uses .so).
- Updated
BUILD_BYPRODUCTSspecification to use platform-independent library suffix - Updated
OpticalFlow_LIBScache variable to use platform-independent library suffix
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Solved Problem
Using .so library format is not what macOS is building (dylib). This approach is more general.
Solution
Changelog Entry
For release notes:
Alternatives
Not that I know of.
Test coverage
CI is happy + locally tested on macOS and Ubuntu.