-
Notifications
You must be signed in to change notification settings - Fork 14.5k
Mag Calibration: require enabled / available mag #25714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
haumarco
wants to merge
1
commit into
main
Choose a base branch
from
mag-calibration_require_enabled_mag
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+32
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔎 FLASH Analysispx4_fmu-v5x [Total VM Diff: 240 byte (0.01 %)]
px4_fmu-v6x [Total VM Diff: 232 byte (0.01 %)]
Updated: 2025-10-09T13:33:08 |
dakejahl
previously approved these changes
Oct 8, 2025
bresch
reviewed
Oct 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
bresch
approved these changes
Oct 9, 2025
…bled (i.e. not prio=0) renaming, change log type
a61022a
to
fd47706
Compare
bresch
approved these changes
Oct 9, 2025
dakejahl
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem & Solution
Previously, it was possible to trigger magnetometer calibration even when all available magnetometers were disabled via their priority parameter. This created a confusing situation where:
This change adds a validation check before calibration starts, counting only magnetometers with priority != 0. If no enabled magnetometers are found, the calibration gets rejected.
To fix this scenario, users must either:
Test Coverage
Tested on hardware with internal and external sensor.