bugfix: NMEA GPS update rate was 0 since num_bytes_read was not being… #23957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Try as I might, I just can't see to get this pull request to add the missing line in this file. Maybe someone can give advice on what I might be doing wrong just to fix the style. |
style fix
dakejahl
previously approved these changes
Nov 17, 2024
|
run |
This was done, after the fact, but I couldn't figure out how to update the PR with the updated patch. Ultimately I used the github UI to hand-edit the formatting issue. Not my first time writing code, but I haven't really used github before. |
dakejahl
approved these changes
Nov 18, 2024
JoelJ18
pushed a commit
to microstrain-robotics/PX4-Autopilot
that referenced
this pull request
Jan 27, 2025
PX4#23957) * bugfix: NMEA GPS update rate was 0 since num_bytes_read was not being updated * Update gps.cpp style fix * make format --------- Co-authored-by: Jacob Dahl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
When using NMEA GPS format, the GPS updates rate was always shown as 0. This was due to the _num_bytes_read field not being updated when the serial messages were read/parsed.
Fixes #23903
Solution
Changelog Entry
For release notes: