Skip to content

Update the use of keccak256 and call(). #1008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 14, 2018
Merged

Update the use of keccak256 and call(). #1008

merged 1 commit into from
Jun 14, 2018

Conversation

chriseth
Copy link
Contributor

🚀 Description

Update how .call() and keccak256() will be required to be used starting from Solidity 0.5.0.

@chriseth
Copy link
Contributor Author

I have seen that you have already changed some of the keccak256 calls, but I think the call() part is new.

@axic
Copy link
Contributor

axic commented Jun 14, 2018

Clarification: upcoming Solidity 0.5.0 will only support a single bytes argument for the raw call. This change is backwards compatible given the project uses at least Solidity 0.4.22.

@axic
Copy link
Contributor

axic commented Jun 14, 2018

Rebased against master.

@chriseth
Copy link
Contributor Author

Thanks, alex!

frangio
frangio approved these changes Jun 14, 2018
View reviewed changes
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @chriseth and @axic !

@frangio frangio merged commit b4406d3 into OpenZeppelin:master Jun 14, 2018
@axic axic deleted the callAndHash branch June 14, 2018 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frangio frangio frangio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chriseth @axic @frangio