Use abi.encodeWithSignature together with raw call() (#1008)

chriseth · frangio · commit b4406d385fd2 · 2018-06-14T18:50:39.000-03:00
diff --git a/contracts/mocks/ReentrancyMock.sol b/contracts/mocks/ReentrancyMock.sol
@@ -24,11 +24,10 @@ contract ReentrancyMock is ReentrancyGuard {
   }
 
   function countThisRecursive(uint256 n) public nonReentrant {
-    bytes4 func = bytes4(keccak256("countThisRecursive(uint256)"));
     if (n > 0) {
       count();
       // solium-disable-next-line security/no-low-level-calls
-      bool result = address(this).call(func, n - 1);
+      bool result = address(this).call(abi.encodeWithSignature("countThisRecursive(uint256)", n - 1));
       require(result == true);
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -24,11 +24,10 @@ contract ReentrancyMock is ReentrancyGuard {`
`24`	`24`	`}`
`25`	`25`
`26`	`26`	`function countThisRecursive(uint256 n) public nonReentrant {`
`27`		`- bytes4 func = bytes4(keccak256("countThisRecursive(uint256)"));`
`28`	`27`	`if (n > 0) {`
`29`	`28`	`count();`
`30`	`29`	`// solium-disable-next-line security/no-low-level-calls`
`31`		`- bool result = address(this).call(func, n - 1);`
	`30`	`+ bool result = address(this).call(abi.encodeWithSignature("countThisRecursive(uint256)", n - 1));`
`32`	`31`	`require(result == true);`
`33`	`32`	`}`
`34`	`33`	`}`