Draft: Forge global makefile changes #24029
Draft
+114
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Till Wegmueller <[email protected]>
Signed-off-by: Till Wegmueller <[email protected]>
Signed-off-by: Till Wegmueller <[email protected]>
Signed-off-by: Till Wegmueller <[email protected]>
Signed-off-by: Till Wegmueller <[email protected]>
Signed-off-by: Till Wegmueller <[email protected]>
Signed-off-by: Till Wegmueller <[email protected]>
Signed-off-by: Till Wegmüller <[email protected]>
Signed-off-by: Till Wegmueller <[email protected]>
Signed-off-by: Till Wegmueller <[email protected]>
Signed-off-by: Till Wegmueller <[email protected]>
Signed-off-by: Till Wegmueller <[email protected]>
Signed-off-by: Till Wegmueller <[email protected]>
Signed-off-by: Till Wegmueller <[email protected]>
mtelka
suggested changes
Oct 3, 2025
|
|
||
| bootstrap-pkgdev: | ||
| @echo "Bootstrapping pkgdev via cargo from toasterson/forge" | ||
| cargo install --git https://github.com/toasterson/forge pkgdev |
Contributor
There was a problem hiding this comment.
Could you please publish forge at crates.io and then we should package it regularly. This cargo install looks like a nasty hack we should avoid.
Thank you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the global makefile changes to oi-userland and once we merge #24028 this should not display the changes to forge.mk and common.mk anymore.
These changes should be save but we may need to discuss and find a test strategy.
I will make the changes to the individual components once we coordinated integration of this and #24028