Forge base commit #24028
Open
Forge base commit #24028
+85
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Till Wegmueller <[email protected]>
Signed-off-by: Till Wegmueller <[email protected]>
Signed-off-by: Till Wegmueller <[email protected]>
Signed-off-by: Till Wegmueller <[email protected]>
Signed-off-by: Till Wegmueller <[email protected]>
Signed-off-by: Till Wegmueller <[email protected]>
Signed-off-by: Till Wegmueller <[email protected]>
Signed-off-by: Till Wegmüller <[email protected]>
Signed-off-by: Till Wegmueller <[email protected]>
Signed-off-by: Till Wegmueller <[email protected]>
Signed-off-by: Till Wegmueller <[email protected]>
Signed-off-by: Till Wegmueller <[email protected]>
Signed-off-by: Till Wegmueller <[email protected]>
|
Will squash this once it's Ok. |
This was referenced Oct 3, 2025
mtelka
suggested changes
Oct 3, 2025
| # | ||
|
|
||
| # Allow overriding via environment and default to relying on PATH | ||
| PKGDEV ?= pkgdev |
There was a problem hiding this comment.
# which pkgdev
no pkgdev in /usr/sbin /usr/bin
#
|
|
||
| # Ensure Cargo-installed tools (e.g., pkgdev) are on PATH | ||
| PATH := $(PATH):$(HOME)/.cargo/bin | ||
| export PATH |
There was a problem hiding this comment.
Since you include this file from common.mk this will affect virtually all components. I'm sure we do not want that. Please do not change PATH here and please do not export anything here. Thank you.
| .PHONY: generate-package-kdl | ||
|
|
||
| # Generate package.kdl using pkgdev with component metadata | ||
| generate-package-kdl: |
There was a problem hiding this comment.
Why do we need an unusable target? I'm sorry, but this makes no sense. Please postpone this change once we do have the pkgdev tool available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit contains the base and safe changes to oi-userland only creating and making forge.mk available. other changes will be put into other PR's