Skip to content

Include example config, verify it is up-to-date, and install it #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 17, 2025
Merged

Include example config, verify it is up-to-date, and install it #87

merged 4 commits into from
Mar 17, 2025

Conversation

luke-jr
Copy link
Contributor

@luke-jr luke-jr commented Mar 16, 2025

Built on #84

@luke-jr luke-jr added the documentation Improvements or additions to documentation label Mar 16, 2025
@luke-jr luke-jr added this to the v0.3.0 milestone Mar 16, 2025
@luke-jr luke-jr mentioned this pull request Mar 16, 2025
Closed
wizkid057
wizkid057 approved these changes Mar 17, 2025
View reviewed changes
Copy link
Member

@wizkid057 wizkid057 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK.

Not a blocker, but can we stash "generated_example_datum_gateway_config.json" somewhere other than the base directory? That's my only reservation since it seems a bit out of place there.

@luke-jr luke-jr merged commit 18f1a2a into OCEAN-xyz:master Mar 17, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wizkid057 wizkid057 wizkid057 approved these changes

@BitcoinMechanic BitcoinMechanic Awaiting requested review from BitcoinMechanic

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@luke-jr @wizkid057