Skip to content

Create example datum_gateway_config.json #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

szarka
Copy link
Contributor

@szarka szarka commented Dec 14, 2024

Created complete example datum_gateway_config.json using the defaults documented in datum_gateway --help as much as possible. Also creates /share/examples path for it.

Created complete example datum_gateway_config.json using the defaults documented in datum_gateway --help as much as possible.
@luke-jr luke-jr added the enhancement New feature or request label Dec 14, 2024
@luke-jr
Copy link
Contributor

luke-jr commented Dec 14, 2024

Should the example have fields that normally would be omitted?

@luke-jr luke-jr added this to the v0.3.0 milestone Dec 14, 2024
@szarka
Copy link
Contributor Author

szarka commented Dec 14, 2024

My rationale was that it would provide a complete starting point for someone who wanted to customize, with defaults documented. (Would have commented out the ones that are at defaults, but no way I know of in JSON.)

@wizkid057
Copy link
Member

While examples are nice, I'm not sure we want to have to always update the example any time something is tweaked with the conf mechanisms...

I wonder if it'd make more sense to modify datum_conf.c to be able to just generate an example config by giving a command line option... similar to how it does --help ... this way it's always up to date, and can specify if you want to a full example with all defaults or just required fields, too.

Something like --example-conf and --example-conf-full that for options that just spit out the example and exit. Should be pretty trivial to generate.

@szarka
Copy link
Contributor Author

szarka commented Dec 14, 2024

Seems like --help is already almost there; just don't include the comments for --example-conf-full?

@allan-mobley-jr

This comment was marked as off-topic.

@luke-jr
Copy link
Contributor

luke-jr commented Mar 16, 2025

How about #87?

@luke-jr luke-jr closed this Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants