[17.0][MIG] stock_exception #2063
Conversation
|
/ocabot migration stock_exception |
Nikul-OSI
force-pushed
the
17.0-mig-stock_exception
branch
from
de1e3cc to
2eecda2
Compare
|
@rousseldenis @patrickrwilson Code updated and All checks green. Can you please take a look? |
Nikul-OSI
force-pushed
the
17.0-mig-stock_exception
branch
from
2eecda2 to
8fe9539
Compare
| return rec._popup_exceptions() | ||
| return super().action_confirm() | ||
|
|
||
| def button_validate(self): |
There was a problem hiding this comment.
@Urvisha-OSI Could you update DESCRIPTION and/or USAGE to reflect this change ?
There was a problem hiding this comment.
@rousseldenis I added a sentence to the Description file.
|
LGTM |
|
@Urvisha-OSI Hi! are you going to continue with this migration? Please tell. Thanks! |
|
@rousseldenis Can i take responsability of migrating this module on another PR? |
I'm ok with that to get this over the finish line, I'm not sure why pre-commit is failing so if your PR passes we can go with that one. |
|
@Urvisha-OSI Could you rebase ? |
|
@Urvisha-OSI HI! there is a problem with the pre-commit, but the rest is fine. Could you fix it? |
|
@Urvisha-OSI Hi, could you check the CI here? |
Murtaza-OSI
force-pushed
the
17.0-mig-stock_exception
branch
4 times, most recently
from
c75e39b to
72f180a
Compare
| return rec._popup_exceptions() | ||
| return super().action_confirm() | ||
|
|
||
| def button_validate(self): |
There was a problem hiding this comment.
Check the last v16 version, which includes tests for button_validate. See if you can add them on this migration.
UPD the code.
Adding some more info to the description for when exceptions are checked.
Murtaza-OSI
force-pushed
the
17.0-mig-stock_exception
branch
from
72f180a to
9d6959e
Compare
|
@rousseldenis @mav-adhoc Could you please review and proceed? |
|
This PR has the |
No description provided.