[MIG] stock_exception: Migration to 17.0

Adding some more info to the description for when exceptions are checked.

Author: urvisha-serpentcs

stock_exception/README.rst

@@ -64,6 +64,11 @@ Contributors
 
 -  Tharathip Chaweewongphan <[email protected]>
 
+-  Open Source Integrators http://www.opensourceintegrators.com
+
+   -  Urvisha Desai [email protected]
+   -  Nikul Chaudhary [email protected]
+
 Maintainers
 -----------
 

stock_exception/models/stock.py

@@ -43,6 +43,12 @@ def action_confirm(self):
                 return rec._popup_exceptions()
         return super().action_confirm()
 
+    def button_validate(self):
+        for rec in self:
+            if rec.detect_exceptions() and not rec.ignore_exception:
+                return rec._popup_exceptions()
+        return super().button_validate()
+
     @api.model
     def _get_popup_action(self):
         action = self.env.ref("stock_exception.action_stock_exception_confirm")

stock_exception/readme/CONTRIBUTORS.md

@@ -1 +1,6 @@
 - Tharathip Chaweewongphan \<<[email protected]>\>
+
+* Open Source Integrators <http://www.opensourceintegrators.com>
+
+  * Urvisha Desai <[email protected]>
+  * Nikul Chaudhary <[email protected]>

stock_exception/readme/DESCRIPTION.md

@@ -1,6 +1,7 @@
 This module allows you attach several customizable exceptions to your
 stock picking in a way that you can filter pickings by exceptions type
-and fix them.
+and fix them. Exceptions are checked via a scheduled action as well as
+during confirmation and validation.
 
 This is especially useful in an scenario for mass stock picking import,
 because it's likely some pickings have errors when you import them (like

stock_exception/static/description/index.html

@@ -407,6 +407,11 @@ <h2><a class="toc-backref" href="#toc-entry-3">Authors</a></h2>
 <h2><a class="toc-backref" href="#toc-entry-4">Contributors</a></h2>
 <ul class="simple">
 <li>Tharathip Chaweewongphan &lt;<a class="reference external" href="mailto:tharathipc&#64;ecosoft.co.th">tharathipc&#64;ecosoft.co.th</a>&gt;</li>
+<li>Open Source Integrators <a class="reference external" href="http://www.opensourceintegrators.com">http://www.opensourceintegrators.com</a><ul>
+<li>Urvisha Desai <a class="reference external" href="mailto:udesai&#64;opensourceintegrators.com">udesai&#64;opensourceintegrators.com</a></li>
+<li>Nikul Chaudhary <a class="reference external" href="mailto:nchaudhary&#64;opensourceintegrators.com">nchaudhary&#64;opensourceintegrators.com</a></li>
+</ul>
+</li>
 </ul>
 </div>
 <div class="section" id="maintainers">

stock_exception/tests/__init__.py

@@ -0,0 +1 @@
+from . import test_stock_exception

stock_exception/tests/test_stock_exception.py

@@ -0,0 +1,106 @@
+# Copyright 2024 Open Source Integrators
+# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl.html)
+from odoo.tests import Form
+from odoo.tests.common import TransactionCase
+
+
+class TestStockPicking(TransactionCase):
+    def setUp(self):
+        super().setUp()
+        stock_location = self.env.ref("stock.stock_location_stock")
+        customer_location = self.env.ref("stock.stock_location_customers")
+        product = self.env.ref("product.product_product_4")
+        picking_type = self.env.ref("stock.picking_type_out")
+        # Create a picking in 'assigned' state with exceptions
+        self.picking_with_exceptions = self.env["stock.picking"].create(
+            {
+                "name": "Test Picking With Exceptions 2",
+                "state": "assigned",
+                "location_id": stock_location.id,
+                "location_dest_id": customer_location.id,
+                "picking_type_id": picking_type.id,
+                "move_ids": [
+                    (
+                        0,
+                        0,
+                        {
+                            "name": "Test Move With Exceptions",
+                            "product_id": product.id,
+                            "product_uom_qty": 1,
+                            "quantity": 1,
+                            "product_uom": self.env.ref("uom.product_uom_unit").id,
+                            "location_id": stock_location.id,
+                            "location_dest_id": customer_location.id,
+                        },
+                    )
+                ],
+                "ignore_exception": False,
+            }
+        )
+
+        self.exception = self.env["exception.rule"].create(
+            {
+                "name": "Demand Quantity not positive",
+                "description": "Demand Quantity not positive",
+                "sequence": 50,
+                "model": "stock.move",
+                "code": "if self.product_uom_qty == 0: failed=True",
+                "active": True,
+            }
+        )
+
+    def test_detect_exceptions(self):
+        # Test that exceptions are detected for the picking with exceptions
+        exceptions = self.picking_with_exceptions.detect_exceptions()
+        self.assertFalse(exceptions, "Exceptions shouldn't be detected")
+        move = self.picking_with_exceptions.move_ids[0]
+        move._reverse_field()
+        move.write({"product_uom_qty": 0})
+        exceptions = self.picking_with_exceptions.detect_exceptions()
+        self.assertTrue(exceptions, "Exceptions should be detected")
+
+    def test_button_validate_with_exceptions(self):
+        move = self.picking_with_exceptions.move_ids[0]
+        move.write({"product_uom_qty": 0})
+        move.write({"quantity": 1})
+        # Result returns a dict in case it detects an exception,
+        # otherwise it returns 'True'
+        result = self.picking_with_exceptions.button_validate()
+
+        # Verify the result of the button_validate action
+        # If exceptions detected, the result should be different from 'True'
+        self.assertNotEqual(
+            result, True, f"Expected result not to be True, but got {type(result)}"
+        )
+
+    def test_onchange_ignore_exception(self):
+        # Change state and verify onchange behavior for picking
+        self.picking_with_exceptions.onchange_ignore_exception()
+        self.picking_with_exceptions._reverse_field()
+        self.picking_with_exceptions.write(
+            {"state": "waiting", "ignore_exception": True}
+        )
+        self.assertTrue(self.picking_with_exceptions.ignore_exception)
+
+    def test_confirm_picking(self):
+        self.stock_exception = self.env["exception.rule"].create(
+            {
+                "name": "No Partner",
+                "description": "No Partner",
+                "sequence": 10,
+                "model": "stock.picking",
+                "exception_type": "by_py_code",
+                "code": "if not self.partner_id: failed=True",
+            }
+        )
+        exception_action = self.picking_with_exceptions.action_confirm()
+        self.assertEqual(exception_action.get("res_model"), "stock.exception.confirm")
+        exception_form = Form(
+            self.env["stock.exception.confirm"].with_context(
+                **exception_action.get("context")
+            ),
+        )
+        stock_exception = exception_form.save()
+        stock_exception.ignore = True
+        self.picking_with_exceptions.test_all_draft_pickings()
+        stock_exception.action_confirm()

stock_exception/views/stock_view.xml

@@ -26,7 +26,7 @@
                     class="alert alert-danger"
                     role="alert"
                     style="margin-bottom:0px;"
-                    attrs="{'invisible': [('exceptions_summary', '=', False)]}"
+                    invisible="not exceptions_summary"
                 >
                     <p>
                         <strong
@@ -46,7 +46,7 @@
             <xpath expr="//field[@name='date_deadline']/.." position="inside">
                 <field
                     name="ignore_exception"
-                    states="waiting,confirmed,assigned"
+                    invisible="state not in ('waiting','confirmed','assigned')"
                     groups='base_exception.group_exception_rule_manager'
                 />
                 <field name="exception_ids" widget="many2many_tags" readonly="True" />