libexpr: allocate ExprOpHasAttr's AttrPath in Exprs::alloc #14149
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
For big picture motivation, see the tracking issue
This PR moves the data from the vector
ExprOpHasAttr::attrPathinto ourExprsarena, and then refers to it by astd::span<AttrName>. Unlike forExprSelect, here we do not benefit from separating out the length and start pointer of thestd::span, since alignment would bring us back up to 16 bytes anyways..ExprOpHasAttrby going fromstd::vector(24 bytes) tostd::span<AttrName>(16 bytes)Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.