libexpr: allocate ExprSelect's AttrPath in Expr::alloc #14124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Radvendii
force-pushed
the
exprselect-alloc
branch
from
80a5bc1 to
ce639af
Compare
Ericson2314
reviewed
Sep 30, 2025
Ericson2314
reviewed
Sep 30, 2025
Ericson2314
reviewed
Sep 30, 2025
Ericson2314
reviewed
Sep 30, 2025
Radvendii
force-pushed
the
exprselect-alloc
branch
2 times, most recently
from
112b667 to
e5c50bf
Compare
Radvendii
changed the title
xokdvium
reviewed
Oct 3, 2025
Contributor
xokdvium
left a comment
xokdvium
left a comment
There was a problem hiding this comment.
Some nitpicks. With those fixed and squashed looks will be good to go
Radvendii
force-pushed
the
exprselect-alloc
branch
from
e5c50bf to
8d7a164
Compare
xokdvium
reviewed
Oct 3, 2025
Radvendii
force-pushed
the
exprselect-alloc
branch
from
8d7a164 to
cb40ced
Compare
xokdvium
force-pushed
the
exprselect-alloc
branch
from
cb40ced to
5693a58
Compare
xokdvium
force-pushed
the
exprselect-alloc
branch
from
5693a58 to
76a9298
Compare
xokdvium
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
For big picture motivation, see the tracking issue
This PR moves the data from the vector
ExprSelect::attrPathinto ourExprsarena, and then refers to it by anAttrName *and auint32_tlength.ExprSelectby going fromstd::vector(24 bytes) toAttrName *(8 bytes) anduint32_t(length)ExprSelectof padding (PosIdxwas followed by 4 bytes of padding)This change (and several to follow) are not required for indexification of
Expr *s or cleaning up parsing leaks, but I thought it would be nice to finish up these changes first so Exprs are not left in a half-way changed state.Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.