Bulk v2 accumulo 4894 rebased #3092
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WIP adapt DW PR#2568 to use accumulo PR#4898 These draft changes build on #2568 with the following differences. * Compute bulkv2 load plans using new unreleased APIs in accumulo PR 4898 * The table splits are loaded at the beginning of writing to rfiles instead of at the end. Not sure about the overall implications on on memory use in reducers of this change. The load plan could be computed after the rfile is closed using a new API in 4898 if defering the loading of tablet splits is desired. * Switches to using accumulo public APIs for writing rfiles instaead of internal accumulo methods. Well public once they are actually released. * The algorithm to compute the load plan does less work per key/value. Should be rougly constant time vs log(N). * Adds a simple SortedList class. This reason this was added is that this code does binary searches on list, however it was not certain those list were actually sorted. If the list was not sorted it would not cause exceptions in binary search but could lead to incorrect load plans and lost data. This new SortedList class ensures list are sorted and allows this assurance to travel around in the code. Maybe this change should be its own PR.
Block zookeeper deps from accumulo Version mismatchs between zookeeper-jute was causing build failures. Excluded the zookeeper deps to ensure the correct zookeeper version was pulled in from elsewhere.
Removes SortedList for now
- Remove V2_LOCAL_MAPPING mode since it is unused - Additional log4j updates for slf4j 2.x compatibility - Quickstart fixes - Other minor cleanup
|
Replaces and closes #2727 |
Closed
ddanielr
reviewed
Aug 12, 2025
ddanielr
approved these changes
Aug 12, 2025
avgAGB
approved these changes
Aug 13, 2025
skyler-kv
pushed a commit
that referenced
this pull request
Aug 26, 2025
Co-authored-by: keith-ratcliffe <[email protected]> Co-authored-by: Daniel Roberts ddanielr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.