Skip to content

Conversation

EmmaQiaoCh
Copy link
Collaborator

@EmmaQiaoCh EmmaQiaoCh commented Jul 31, 2025

Summary by CodeRabbit

  • Chores
    • Added a new dependency to the application requirements.

Description

Test Coverage

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

Copy link
Contributor

coderabbitai bot commented Jul 31, 2025

📝 Walkthrough

Walkthrough

A new dependency, triton==3.3.1, has been added to the requirements.txt file. No other dependencies or files were modified.

Changes

Cohort / File(s) Change Summary
Dependency Update
requirements.txt
Added triton==3.3.1 to the list of required packages.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d38c26b and fb630b6.

📒 Files selected for processing (1)
  • requirements.txt (1 hunks)
🔇 Additional comments (1)
requirements.txt (1)

64-64: Review Triton dependency and compatibility

  • Only triton==3.3.1 is pinned in requirements.txt; no other triton* entries (no tritonclient) or implicit pulls from transformers==4.53.1 or flashinfer-python==0.2.5.
  • No torch==X.Y pin detected—please ensure your environment installs PyTorch ≥ 2.7 and verify its bundled Triton sub-module does not conflict with the separately installed triton wheel.
  • Confirm that you indeed intend to depend on OpenAI’s triton package (compiler backend). If you meant NVIDIA Triton Inference Server client, replace it with tritonclient.
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@EmmaQiaoCh
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #13638 [ run ] triggered by Bot

@chzblych chzblych changed the title [Infra] - Pin the version for triton [None][infra] Pin the version for triton to 3.3.1 Jul 31, 2025
@tensorrt-cicd
Copy link
Collaborator

PR_Github #13638 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #10234 completed with status: 'SUCCESS'

@liji-nv liji-nv merged commit baece56 into NVIDIA:main Jul 31, 2025
3 checks passed
chzblych pushed a commit to chzblych/TensorRT-LLM that referenced this pull request Jul 31, 2025
chzblych pushed a commit to chzblych/TensorRT-LLM that referenced this pull request Aug 1, 2025
chzblych added a commit that referenced this pull request Aug 1, 2025
Signed-off-by: qqiao <[email protected]>
Signed-off-by: Yanchao Lu <[email protected]>
Co-authored-by: Emma Qiao <[email protected]>
chzblych added a commit to chzblych/TensorRT-LLM that referenced this pull request Aug 1, 2025
chzblych added a commit that referenced this pull request Aug 1, 2025
hlu1 pushed a commit that referenced this pull request Aug 5, 2025
lancelly pushed a commit to lancelly/TensorRT-LLM that referenced this pull request Aug 6, 2025
lancelly pushed a commit to lancelly/TensorRT-LLM that referenced this pull request Aug 6, 2025
jain-ria pushed a commit to jain-ria/TensorRT-LLM that referenced this pull request Aug 7, 2025
jain-ria pushed a commit to jain-ria/TensorRT-LLM that referenced this pull request Aug 7, 2025
jhaotingc pushed a commit to jhaotingc/TensorRT-LLM that referenced this pull request Aug 25, 2025
jhaotingc pushed a commit to jhaotingc/TensorRT-LLM that referenced this pull request Aug 25, 2025
symphonylyh pushed a commit to symphonylyh/TensorRT-LLM that referenced this pull request Aug 26, 2025
…VIDIA#6282 NVIDIA#6279

* [None][infra] Pin the version for triton to 3.3.1 (NVIDIA#6508)

Signed-off-by: qqiao <[email protected]>

* [None][infra] Pin the version for triton to 3.3.1 (NVIDIA#6508) (NVIDIA#6519) (NVIDIA#6549)

Signed-off-by: Yanchao Lu <[email protected]>

* [fix]: use safeInitRowMax instead of fp32_lowest to avoid NaN (NVIDIA#7087)

Signed-off-by: Yao Yao <[email protected]>

* [None][fix] Fix a numerical stability issue for XQA with spec dec

Signed-off-by: Yao Yao <[email protected]>

* fix typo

Signed-off-by: Jhao-Ting Chen <[email protected]>

* fix precompiled multi_query_token kernel not having is_fp8_out hash key (NVIDIA#6279)

Signed-off-by: Jhao-Ting Chen <[email protected]>

* [fix] Fix missing fields in xqa kernel cache key (NVIDIA#6282)

Signed-off-by: Yao Yao <[email protected]>

---------

Signed-off-by: qqiao <[email protected]>
Signed-off-by: Yanchao Lu <[email protected]>
Signed-off-by: Yao Yao <[email protected]>
Signed-off-by: Jhao-Ting Chen <[email protected]>
Co-authored-by: Emma Qiao <[email protected]>
Co-authored-by: Yanchao Lu <[email protected]>
Co-authored-by: Yao Yao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants