Skip to content

Commit d38c26b

Browse files
authored
[Infra][TRTLLM-5633] - Fix merge waive list (#6504)
Signed-off-by: Yiqing Yan <[email protected]>
1 parent 1ee7a08 commit d38c26b

File tree

2 files changed

+11
-4
lines changed

2 files changed

+11
-4
lines changed

jenkins/L0_MergeRequest.groovy

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -347,12 +347,15 @@ def mergeWaiveList(pipeline, globalVars)
347347
// Get waive list diff in current MR
348348
def diff = getMergeRequestOneFileChanges(pipeline, globalVars, "tests/integration/test_lists/waives.txt")
349349

350+
// Write diff to a temporary file to avoid shell escaping issues
351+
writeFile file: 'diff_content.txt', text: diff
352+
350353
// Merge waive lists
351354
sh """
352355
python3 mergeWaiveList.py \
353356
--cur-waive-list=waives_CUR_${env.gitlabCommit}.txt \
354357
--latest-waive-list=waives_TOT_${targetBranchTOTCommit}.txt \
355-
--diff='${diff}' \
358+
--diff-file=diff_content.txt \
356359
--output-file=waives.txt
357360
"""
358361
trtllm_utils.uploadArtifacts("waives*.txt", "${UPLOAD_PATH}/waive_list/")

jenkins/scripts/mergeWaiveList.py

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,9 @@
77
# 3. Merge the current MR waive list and TOT waive list, and remove the removed lines from the step 1
88

99

10-
def get_remove_lines_from_diff(diff):
10+
def get_remove_lines_from_diff_file(diff_file):
11+
with open(diff_file, 'r') as f:
12+
diff = f.read()
1113
lines = diff.split('\n')
1214
remove_lines = [
1315
line[1:] + '\n' for line in lines
@@ -47,10 +49,12 @@ def merge_waive_list(cur_list, main_list, remove_lines, output_file):
4749
parser.add_argument('--latest-waive-list',
4850
required=True,
4951
help='Latest waive list')
50-
parser.add_argument('--diff', required=True, help='Diff of the waive list')
52+
parser.add_argument('--diff-file',
53+
required=True,
54+
help='File containing diff of the waive list')
5155
parser.add_argument('--output-file', required=True, help='Output file')
5256
args = parser.parse_args(sys.argv[1:])
5357
cur_list = parse_waive_txt(args.cur_waive_list)
5458
main_list = parse_waive_txt(args.latest_waive_list)
55-
remove_lines = get_remove_lines_from_diff(args.diff)
59+
remove_lines = get_remove_lines_from_diff_file(args.diff_file)
5660
merge_waive_list(cur_list, main_list, remove_lines, args.output_file)

0 commit comments

Comments
 (0)