Fix wrong URL being fetched for npm's scoped package #405
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If derivation's src is from a npm package and if such npm package is scoped (e.g.
@org/packagenameinstead ofpackagename), wrong URL would be used to fetch latest version and failed.To reproduce:
Note that the log shows nix-update tries to fetch the URL:
While the correct URL should be:
This PR fixes this and added two test cases to test for URL generation for both scoped and non-scoped packages.