Merge pull request #405 from limouren/fix-npm-scoped-package

Fix wrong URL being fetched for npm's scoped package

Author: Mic92

nix_update/version/npm.py

@@ -11,7 +11,8 @@ def fetch_npm_versions(url: ParseResult) -> list[Version]:
     if url.netloc != "registry.npmjs.org":
         return []
     parts = url.path.split("/")
-    package = parts[1]
+    # Handle scoped packages like @myorg/mypackage
+    package = f"{parts[1]}/{parts[2]}" if parts[1].startswith("@") else parts[1]
     npm_url = f"https://registry.npmjs.org/{package}/latest"
     info(f"fetch {npm_url}")
     resp = urllib.request.urlopen(npm_url)

tests/test_npm_fetch_latest_version.py

@@ -0,0 +1,45 @@
+import io
+import unittest.mock
+from urllib.parse import urlparse
+
+from nix_update.version import fetch_latest_version
+from nix_update.version.version import VersionPreference
+from tests import conftest
+
+
+def fake_npm_urlopen(url: str) -> io.BytesIO:
+    if url == "https://registry.npmjs.org/@anthropic-ai/claude-code/latest":
+        return io.BytesIO(b'{"version": "1.0.43"}')
+
+    if url == "https://registry.npmjs.org/express/latest":
+        return io.BytesIO(b'{"version": "4.21.2"}')
+
+    raise ValueError(f"Unexpected URL in test: {url}")  # noqa: EM102, TRY003
+
+
+def test_scoped_npm(helpers: conftest.Helpers) -> None:
+    del helpers
+    with unittest.mock.patch("urllib.request.urlopen", fake_npm_urlopen):
+        assert (
+            fetch_latest_version(
+                urlparse(
+                    "https://registry.npmjs.org/@anthropic-ai/claude-code/-/claude-code-1.0.42.tgz",
+                ),
+                VersionPreference.STABLE,
+                "(.*)",
+            ).number
+            == "1.0.43"
+        )
+
+
+def test_regular_npm(helpers: conftest.Helpers) -> None:
+    del helpers
+    with unittest.mock.patch("urllib.request.urlopen", fake_npm_urlopen):
+        assert (
+            fetch_latest_version(
+                urlparse("https://registry.npmjs.org/express/-/express-4.21.1.tgz"),
+                VersionPreference.STABLE,
+                "(.*)",
+            ).number
+            == "4.21.2"
+        )