Skip to content

Fix stray space after tool-tipped text #886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2019
Merged

Fix stray space after tool-tipped text #886

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a017b40
Removed space after tooltip
alyip98 Jun 10, 2019
80773e6
Add tests for tooltip spacing
alyip98 Jun 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions asset/js/vue-strap.min.js
View file
Open in desktop

Large diffs are not rendered by default.

24 changes: 12 additions & 12 deletions test/functional/test_site/expected/markbind/js/vue-strap.min.js
View file
Open in desktop

Large diffs are not rendered by default.

10 changes: 10 additions & 0 deletions test/functional/test_site/expected/siteData.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,16 @@
"globalOverrideProperty": "Overridden by global override",
"globalAndFrontMatterOverrideProperty": "Overridden by global override"
},
{
"headings": {
"569-stray-space-after-tooltip": "569: Stray space after tooltip"
},
"src": "testTooltipSpacing.mbd",
"title": "Tooltip Spacing Test",
"layout": "default",
"globalOverrideProperty": "Overridden by global override",
"globalAndFrontMatterOverrideProperty": "Overridden by global override"
},
{
"headings": {
"thumbnail-test": "Thumbnail test",
Expand Down
63 changes: 63 additions & 0 deletions test/functional/test_site/expected/testTooltipSpacing.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,63 @@
<!DOCTYPE html>
<html>

<head>
<meta name="default-head-top">
<meta charset="utf-8">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="generator" content="MarkBind 2.5.1">
<meta name="viewport" content="width=device-width, initial-scale=1">
<title>Tooltip Spacing Test</title>
<link rel="stylesheet" href="markbind/css/bootstrap.min.css">
<link rel="stylesheet" href="markbind/css/bootstrap-vue.min.css">
<link rel="stylesheet" href="markbind/fontawesome/css/all.min.css">
<link rel="stylesheet" href="markbind/glyphicons/css/bootstrap-glyphicons.min.css">
<link rel="stylesheet" href="markbind/css/github.min.css">
<link rel="stylesheet" href="markbind/css/markbind.css">
<link rel="stylesheet" href="STYLESHEET_LINK">
<link rel="stylesheet" href="markbind/layouts/default/styles.css">


<meta name="default-head-bottom">
<link rel="icon" href="/test_site/favicon.png">
</head>

<body>
<div id="app">
<div id="flex-body">
<div id="content-wrapper">
<h1 id="569-stray-space-after-tooltip">569: Stray space after tooltip<a class="fa fa-anchor" href="#569-stray-space-after-tooltip"></a></h1>
<pre><code class="hljs">&lt;tooltip&gt;tooltip&lt;/tooltip&gt;, test

&lt;trigger&gt;trigger&lt;/trigger&gt;, test
</code></pre>
<p>
<tooltip>tooltip</tooltip>, test</p>
<p>
<trigger>trigger</trigger>, test</p>
</div>
</div>
<footer>
<div class="text-center">
Default footer
</div>
</footer>
</div>
</body>
<script src="markbind/js/vue.min.js"></script>
<script src="markbind/js/vue-strap.min.js"></script>
<script src="markbind/js/bootstrap-utility.min.js"></script>
<script src="markbind/js/polyfill.min.js"></script>
<script src="markbind/js/bootstrap-vue.min.js"></script>
<script>
const baseUrl = '/test_site'
const enableSearch = true
</script>
<script src="markbind/js/setup.js"></script>
<script src="SCRIPT_LINK"></script>
<script>
alert("hello")
</script>
<script src="markbind/layouts/default/scripts.js"></script>

</html>
12 changes: 12 additions & 0 deletions test/functional/test_site/expected/testTooltipSpacing.mbd
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
# 569: Stray space after tooltip


```
<tooltip>tooltip</tooltip>, test

<trigger>trigger</trigger>, test
```

<tooltip>tooltip</tooltip>, test

<trigger>trigger</trigger>, test
4 changes: 4 additions & 0 deletions test/functional/test_site/site.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,10 @@
{
"src": "testAnchorGeneration.md",
"title": "Anchor Generation Test"
},
{
"src": "testTooltipSpacing.mbd",
"title": "Tooltip Spacing Test"
},
{
"src": "testThumbnails.md",
Expand Down
12 changes: 12 additions & 0 deletions test/functional/test_site/testTooltipSpacing.mbd
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
# 569: Stray space after tooltip


```
<tooltip>tooltip</tooltip>, test

<trigger>trigger</trigger>, test
```

<tooltip>tooltip</tooltip>, test

<trigger>trigger</trigger>, test
24 changes: 12 additions & 12 deletions test/functional/test_site_algolia_plugin/expected/markbind/js/vue-strap.min.js
View file
Open in desktop

Large diffs are not rendered by default.

24 changes: 12 additions & 12 deletions test/functional/test_site_convert/expected/markbind/js/vue-strap.min.js
View file
Open in desktop

Large diffs are not rendered by default.