Fix stray space after tool-tipped text #886
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chng-Zhi-Xuan
previously approved these changes
Jun 7, 2019
There was a problem hiding this comment.
Creating tests is good for checking if a bug has been fixed, or if a new enhancement / feature is working well.
Creating a test for a small bug seems a little overkill. But I appreciate the thorough testing. We might need to clean up the test_site folder soon as it is getting quite cluttered ...
Chng-Zhi-Xuan
requested changes
Jun 7, 2019
Currently, there is a bug where an extra space appears after text wrapped in a `tooltip` tag. Let's fix that by removing the extra space
Chng-Zhi-Xuan
approved these changes
Jun 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put "X" next to an item, remove the rest)
• [x] Bug fix
Fixes #569
Related PR on vue-strap
What is the rationale for this request?
Remove extra space after tool-tipped text
What changes did you make? (Give an overview)
Remove newline character in Vue template which was being parsed as an extra space
Provide some example code that this change will affect:
There should no longer be a space between 'hello' and ',' in the rendered HTML.
Testing instructions:
Check whether
testTooltipSpacing.htmldemonstrates the correct behavior.Proposed commit message: (wrap lines at 72 characters)
Currently, there is a bug where an extra space appears after text
wrapped in a
tooltiptag.Let's fix that by removing the extra space in the Vue template.