-
Notifications
You must be signed in to change notification settings - Fork 3.6k
releasing 2.5.4
[rebase & merge]
#21126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
(cherry picked from commit f6a9151)
(cherry picked from commit 08292b1)
[create-pull-request] automated change Co-authored-by: Borda <[email protected]> Co-authored-by: Jirka Borovec <[email protected]> (cherry picked from commit 5a2b678)
…ware platforms (#21057) * support more hardware platforms and no longer hard code cuda when call _get_default_process_group_backend_for_device * Apply suggestions from code review --------- Signed-off-by: taozhiwei <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Nicki Skafte Detlefsen <[email protected]> Co-authored-by: Jirka Borovec <[email protected]> (cherry picked from commit 119a640)
…ack (#21068) * fix(tuner/lr_finder): apply LR suggestion after checkpoint restore when used as callback Previously, LearningRateFinder applied the suggested LR before restoring the checkpoint, so the optimizer LR was reverted by the restore step. This caused the callback to print “Learning rate set to …” without persisting the change. Change: - Move LR application to after checkpoint restore and update both the LM attr and active optimizer param groups so the LR persists for training. Tests: - Add unit test [test_lr_finder_callback_applies_lr_after_restore] to assert the optimizer LR matches the LR Finder suggestion after the search completes. * changelog * Apply suggestions from code review --------- Co-authored-by: Nicki Skafte Detlefsen <[email protected]> Co-authored-by: Jirka Borovec <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit 3ed9d4e)
(cherry picked from commit 8d1a734)
Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 5. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4...v5) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit 5751f8c)
…1089) Bumps [coverage](https://github.com/nedbat/coveragepy) from 7.10.3 to 7.10.4. - [Release notes](https://github.com/nedbat/coveragepy/releases) - [Changelog](https://github.com/nedbat/coveragepy/blob/master/CHANGES.rst) - [Commits](nedbat/coveragepy@7.10.3...7.10.4) --- updated-dependencies: - dependency-name: coverage dependency-version: 7.10.4 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit 3ec489e)
…<3.11.0 in /requirements (#21083) build(deps): update matplotlib requirement in /requirements Updates the requirements on [matplotlib](https://github.com/matplotlib/matplotlib) to permit the latest version. - [Release notes](https://github.com/matplotlib/matplotlib/releases) - [Commits](matplotlib/matplotlib@v3.1.1...v3.10.5) --- updated-dependencies: - dependency-name: matplotlib dependency-version: 3.10.5 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit 8ff2607)
…5.0 in /requirements (#21082) build(deps): update ipython[notebook] requirement in /requirements Updates the requirements on [ipython[notebook]](https://github.com/ipython/ipython) to permit the latest version. - [Release notes](https://github.com/ipython/ipython/releases) - [Commits](ipython/ipython@rel-0.8.4...9.4.0) --- updated-dependencies: - dependency-name: ipython[notebook] dependency-version: 9.4.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit 737c1c6)
…>=1.12.0,<1.23.0 in /requirements (#21090) build(deps): update onnxruntime requirement in /requirements Updates the requirements on [onnxruntime](https://github.com/microsoft/onnxruntime) to permit the latest version. - [Release notes](https://github.com/microsoft/onnxruntime/releases) - [Changelog](https://github.com/microsoft/onnxruntime/blob/main/docs/ReleaseManagement.md) - [Commits](microsoft/onnxruntime@v1.12.0...v1.22.1) --- updated-dependencies: - dependency-name: onnxruntime dependency-version: 1.22.1 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit e21ee0e)
* build(deps): bump torch from 2.7.1 to 2.8.0 in /requirements Bumps [torch](https://github.com/pytorch/pytorch) from 2.7.1 to 2.8.0. - [Release notes](https://github.com/pytorch/pytorch/releases) - [Changelog](https://github.com/pytorch/pytorch/blob/main/RELEASE.md) - [Commits](pytorch/pytorch@v2.7.1...v2.8.0) --- updated-dependencies: - dependency-name: torch dependency-version: 2.8.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Apply suggestions from code review --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jirka Borovec <[email protected]> (cherry picked from commit 345c841)
…0.22.1,<1.8.0 in /requirements (#21084) build(deps): update scikit-learn requirement in /requirements Updates the requirements on [scikit-learn](https://github.com/scikit-learn/scikit-learn) to permit the latest version. - [Release notes](https://github.com/scikit-learn/scikit-learn/releases) - [Commits](scikit-learn/scikit-learn@0.22.2...1.7.1) --- updated-dependencies: - dependency-name: scikit-learn dependency-version: 1.7.1 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit 5ac872e)
…1057 (#21092) * debug failing tests for Fabric with `ddp_fork` on PT 2.8 * Revert "let `_get_default_process_group_backend_for_device` support more hardware platforms (#21057)" This reverts commit 119a640. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit 9ca360b)
* build(deps): bump click from 8.1.8 to 8.2.1 in /requirements Bumps [click](https://github.com/pallets/click) from 8.1.8 to 8.2.1. - [Release notes](https://github.com/pallets/click/releases) - [Changelog](https://github.com/pallets/click/blob/main/CHANGES.rst) - [Commits](pallets/click@8.1.8...8.2.1) --- updated-dependencies: - dependency-name: click dependency-version: 8.2.1 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Apply suggestions from code review --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jirka Borovec <[email protected]> (cherry picked from commit 48fa086)
… mutation (#21079) * Fix: AsyncCheckpointIO snapshots tensors to avoid race with parameter mutation Summary - Root cause: Background thread serialized live tensor references; the training thread mutated tensors after scheduling the async save, leading to mixed-step checkpoints. - Fix: Snapshot all tensors on the main thread before submitting the async save using `apply_to_collection(..., torch.Tensor, lambda t: t.detach().clone())`. Implementation - Reproduce the issue in unit test - Clone all tensors in the checkpoint payload on the caller thread to take a point-in-time snapshot. - Supports both positional and keyword `checkpoint` parameters. - Preserves non-tensor values; handles nested containers. - Continues to surface background exceptions on teardown. * chlog --------- Co-authored-by: Jirka B <[email protected]> (cherry picked from commit 2c74bee)
(cherry picked from commit 8ff43d4)
…nce (#20952) * Make asyncio checkpointing work if validate/fit is called more than once. * Apply suggestions from code review * Add assertion to ensure executor is initialized before saving checkpoint * update --------- Co-authored-by: Jirka Borovec <[email protected]> Co-authored-by: Jirka B <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: bhimrazy <[email protected]> (cherry picked from commit ff64a92)
(cherry picked from commit da88f5a)
…strategy` (#21100) * fix mis-alignment column while using rich model summary in DeepSpeed strategy. * test: add minimum gpu requirement in `test_deepspeed_summary_with_rich_model_summary` * chlog --------- Co-authored-by: Jirka B <[email protected]> Co-authored-by: Nicki Skafte Detlefsen <[email protected]> (cherry picked from commit 2460746)
* ci: pin also test requirements for minimal setup * onnx >1.12.0 * numpy >1.20.0 * onnxscript >= 0.1.0 * tensorboard >=2.11 * tensorboardX >=2.6 --------- Co-authored-by: Copilot <[email protected]> (cherry picked from commit a08b64e)
docs: fix log_metrics step description (#20677) Co-authored-by: Alexander Zhipa <[email protected]> (cherry picked from commit b581924)
….2.2,<0.5.0 in /requirements (#21113) build(deps): update onnxscript requirement in /requirements Updates the requirements on [onnxscript](https://github.com/microsoft/onnxscript) to permit the latest version. - [Release notes](https://github.com/microsoft/onnxscript/releases) - [Commits](microsoft/onnxscript@v0.2.2...v0.4.0) --- updated-dependencies: - dependency-name: onnxscript dependency-version: 0.4.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit fdcfe0f)
…1115) Bumps [coverage](https://github.com/nedbat/coveragepy) from 7.10.4 to 7.10.5. - [Release notes](https://github.com/nedbat/coveragepy/releases) - [Changelog](https://github.com/nedbat/coveragepy/blob/master/CHANGES.rst) - [Commits](nedbat/coveragepy@7.10.4...7.10.5) --- updated-dependencies: - dependency-name: coverage dependency-version: 7.10.5 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit c10aeb8)
…=0.18.1,<5.0.0 in /requirements (#21114) build(deps): update myst-parser requirement in /requirements Updates the requirements on [myst-parser](https://github.com/executablebooks/MyST-Parser) to permit the latest version. - [Release notes](https://github.com/executablebooks/MyST-Parser/releases) - [Changelog](https://github.com/executablebooks/MyST-Parser/blob/master/CHANGELOG.md) - [Commits](executablebooks/MyST-Parser@v0.18.1...v4.0.1) --- updated-dependencies: - dependency-name: myst-parser dependency-version: 4.0.1 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit 91ec79f)
(cherry picked from commit 9e4d469)
* Update versioning governance document per discussion in #21073 * Update docs/source-pytorch/versioning.rst simplify language --------- Co-authored-by: Copilot <[email protected]> Co-authored-by: Jirka Borovec <[email protected]> (cherry picked from commit a8f26e8)
* add h200 support to throughput * add testing * changelog --------- Co-authored-by: Jirka Borovec <[email protected]> (cherry picked from commit e55650d)
⚡ Required checks status: All passing 🟢Groups summary🟢 pytorch_lightning: Tests workflow
These checks are required after the changes to 🟢 pytorch_lightning: Azure GPU
These checks are required after the changes to 🟢 pytorch_lightning: Benchmarks
These checks are required after the changes to 🟢 fabric: Docs
These checks are required after the changes to 🟢 pytorch_lightning: Docs
These checks are required after the changes to 🟢 pytorch_lightning: Docker
These checks are required after the changes to 🟢 lightning_fabric: CPU workflow
These checks are required after the changes to 🟢 lightning_fabric: Azure GPU
These checks are required after the changes to 🟢 mypy
These checks are required after the changes to 🟢 install
These checks are required after the changes to Thank you for your contribution! 💜
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## release/stable #21126 +/- ##
===============================================
- Coverage 87% 87% -0%
===============================================
Files 268 268
Lines 23344 23363 +19
===============================================
+ Hits 20338 20353 +15
- Misses 3006 3010 +4 |
What does this PR do?
regular patch release...
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--21126.org.readthedocs.build/en/21126/