Skip to content

Fix rich progress bar crashing on empty val dataloader sanity checking #21108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 22, 2025
Merged

Fix rich progress bar crashing on empty val dataloader sanity checking #21108

merged 4 commits into from
Aug 22, 2025

Conversation

SkafteNicki
Copy link
Collaborator

@SkafteNicki SkafteNicki commented Aug 22, 2025 •
edited by github-actions bot
Loading

What does this PR do?

Fixes #20605

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--21108.org.readthedocs.build/en/21108/

@SkafteNicki SkafteNicki self-assigned this Aug 22, 2025
@SkafteNicki SkafteNicki added the bug Something isn't working label Aug 22, 2025
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Aug 22, 2025
@Borda Borda merged commit 7e9cea4 into Lightning-AI:master Aug 22, 2025
88 of 90 checks passed
Borda pushed a commit that referenced this pull request Aug 28, 2025
@SkafteNicki @Borda
Fix rich progress bar crashing on empty val dataloader sanity checking (
c110661 
#21108)

* fix sanity check breaking on len=0 val dataloader
* add testing
* changelog

(cherry picked from commit 7e9cea4)
lantiga pushed a commit that referenced this pull request Aug 29, 2025
@SkafteNicki @lantiga
Fix rich progress bar crashing on empty val dataloader sanity checking (
476540f 
#21108)

* fix sanity check breaking on len=0 val dataloader
* add testing
* changelog

(cherry picked from commit 7e9cea4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda approved these changes

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@ethanwharris ethanwharris Awaiting requested review from ethanwharris ethanwharris is a code owner

Assignees

@SkafteNicki SkafteNicki

Labels
bug Something isn't working pl Generic label for PyTorch Lightning package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Training crashes when using RichProgressBar with num_sanity_val_steps but no validation dataloader
2 participants
@SkafteNicki @Borda