Skip to content

Conversation

mcayuelas-ledger
Copy link
Contributor

@mcayuelas-ledger mcayuelas-ledger commented Aug 25, 2025

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • Moving createApi from LLD to common

πŸ“ Description

Migration of the createApi responsible for DADA from the desktop app to the common module, so that it can also be used in LLM. Includes configuration and integration of the createApi into the LLM store.

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Aug 25, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
web-tools Ready Ready Preview Comment Aug 26, 2025 8:29am
3 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
ledger-live-github-bot Ignored Ignored Preview Aug 26, 2025 8:29am
native-ui-storybook Ignored Ignored Preview Aug 26, 2025 8:29am
react-ui-storybook Ignored Ignored Preview Aug 26, 2025 8:29am

@mcayuelas-ledger mcayuelas-ledger requested a review from a team as a code owner August 25, 2025 13:08
@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM common Has changes in live-common labels Aug 25, 2025
LucasWerey
LucasWerey previously approved these changes Aug 25, 2025
@mcayuelas-ledger mcayuelas-ledger force-pushed the feat/llm-store-dada-api-response branch from 596cb47 to bc8932d Compare August 26, 2025 07:59
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
41.7% Coverage on New Code (required β‰₯ 80%)

See analysis details on SonarQube Cloud

@mcayuelas-ledger mcayuelas-ledger merged commit a643b82 into develop Aug 26, 2025
137 of 146 checks passed
@mcayuelas-ledger mcayuelas-ledger deleted the feat/llm-store-dada-api-response branch August 26, 2025 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common desktop Has changes in LLD mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants