feat: migrate createApi Assets from LLD to common and plugged it to LLM

mcayuelas-ledger · mcayuelas-ledger · commit bc8932d4c906 · 2025-08-26T09:58:58.000+02:00
diff --git a/.changeset/thin-waves-appear.md b/.changeset/thin-waves-appear.md
@@ -0,0 +1,7 @@
+---
+"ledger-live-desktop": minor
+"live-mobile": minor
+"@ledgerhq/live-common": minor
+---
+
+Migrate createApi Assets from LLD to live-common and plugged it to LLM
diff --git a/apps/ledger-live-desktop/package.json b/apps/ledger-live-desktop/package.json
@@ -88,7 +88,7 @@
     "@ledgerhq/types-cryptoassets": "workspace:^",
     "@ledgerhq/types-devices": "workspace:^",
     "@ledgerhq/types-live": "workspace:^",
-    "@reduxjs/toolkit": "2.0.1",
+    "@reduxjs/toolkit": "2.8.2",
     "@sentry/electron": "5.2.0",
     "@sentry/node": "8.16.0",
     "@tanstack/react-query": "5.28.9",
diff --git a/apps/ledger-live-desktop/src/newArch/features/ModularDrawer/ModularDrawerFlowManager.stories.tsx b/apps/ledger-live-desktop/src/newArch/features/ModularDrawer/ModularDrawerFlowManager.stories.tsx
@@ -22,7 +22,7 @@ import {
   bitcoinCurrency,
   ethereumCurrency,
 } from "../__mocks__/useSelectAssetFlow.mock";
-import { assetsDataApi } from "./data/state-manager/api";
+import { assetsDataApi } from "@ledgerhq/live-common/modularDrawer/data/state-manager/api";
 import ModularDrawerFlowManager from "./ModularDrawerFlowManager";
 import { ModularDrawerFlowManagerProps } from "./types";
 
diff --git a/apps/ledger-live-desktop/src/newArch/features/ModularDrawer/hooks/useModularDrawerData.ts b/apps/ledger-live-desktop/src/newArch/features/ModularDrawer/hooks/useModularDrawerData.ts
@@ -1,9 +1,9 @@
 import { useMemo } from "react";
 import { CurrenciesByProviderId, LoadingStatus } from "@ledgerhq/live-common/deposit/type";
-import { useAssetsData } from "./useAssetsData";
 import { getLoadingStatus } from "../utils/getLoadingStatus";
 import { findCryptoCurrencyById, findTokenById } from "@ledgerhq/cryptoassets";
 import { CryptoOrTokenCurrency } from "@ledgerhq/types-cryptoassets";
+import { useAssetsData } from "@ledgerhq/live-common/modularDrawer/hooks/useAssetsData";
 
 interface UseModularDrawerDataProps {
   currencies?: CryptoOrTokenCurrency[];
diff --git a/apps/ledger-live-desktop/src/renderer/createStore.ts b/apps/ledger-live-desktop/src/renderer/createStore.ts
@@ -1,7 +1,7 @@
 import { configureStore, Middleware } from "@reduxjs/toolkit";
 import logger from "~/renderer/middlewares/logger";
 import reducers, { State } from "~/renderer/reducers";
-import { assetsDataApi } from "~/newArch/features/ModularDrawer/data/state-manager/api";
+import { assetsDataApi } from "@ledgerhq/live-common/modularDrawer/data/state-manager/api";
 
 type Props = {
   state?: State;
diff --git a/apps/ledger-live-desktop/src/renderer/reducers/index.ts b/apps/ledger-live-desktop/src/renderer/reducers/index.ts
@@ -17,7 +17,7 @@ import trustchain from "./trustchain";
 import { TrustchainStore } from "@ledgerhq/ledger-key-ring-protocol/store";
 import { getEnv } from "@ledgerhq/live-env";
 import countervalues, { CountervaluesState } from "./countervalues";
-import { assetsDataApi } from "~/newArch/features/ModularDrawer/data/state-manager/api";
+import { assetsDataApi } from "@ledgerhq/live-common/modularDrawer/data/state-manager/api";
 
 export type State = {
   accounts: AccountsState;
diff --git a/apps/ledger-live-mobile/__tests__/test-renderer.tsx b/apps/ledger-live-mobile/__tests__/test-renderer.tsx
@@ -44,6 +44,7 @@ import { INITIAL_STATE as AUTH_INITIAL_STATE } from "~/reducers/auth";
 import StyleProvider from "~/StyleProvider";
 import CustomLiveAppProvider from "./CustomLiveAppProvider";
 import { getFeature } from "./featureFlags";
+import { assetsDataApi } from "@ledgerhq/live-common/modularDrawer/data/state-manager/api";
 
 const INITIAL_STATE: State = {
   accounts: ACCOUNTS_INITIAL_STATE,
@@ -68,6 +69,7 @@ const INITIAL_STATE: State = {
   walletconnect: WALLET_CONNECT_INITIAL_STATE,
   walletSync: WALLETSYNC_INITIAL_STATE,
   auth: AUTH_INITIAL_STATE,
+  assetsDataApi: assetsDataApi.reducer(undefined, { type: "INIT" }),
 };
 
 type ExtraOptions = RenderOptions & {
diff --git a/apps/ledger-live-mobile/package.json b/apps/ledger-live-mobile/package.json
@@ -133,7 +133,7 @@
     "@react-navigation/native": "6.1.17",
     "@react-navigation/native-stack": "6.9.26",
     "@react-navigation/stack": "6.3.29",
-    "@reduxjs/toolkit": "2.0.1",
+    "@reduxjs/toolkit": "2.8.2",
     "@segment/analytics-react-native": "2.20.5",
     "@segment/sovran-react-native": "1.1.3",
     "@sentry/react-native": "6.13.0",
diff --git a/apps/ledger-live-mobile/src/actions/types.ts b/apps/ledger-live-mobile/src/actions/types.ts
@@ -41,6 +41,7 @@ import { Steps } from "LLM/features/WalletSync/types/Activation";
 import { NftStatus } from "@ledgerhq/live-nft/types";
 import { SupportedBlockchain } from "@ledgerhq/live-nft/supported";
 import type { CounterValuesState } from "@ledgerhq/live-countervalues/types";
+import { AnyAction } from "redux";
 
 //  === ACCOUNTS ACTIONS ===
 
@@ -655,4 +656,5 @@ export type ActionsPayload =
   | Action<ProtectPayload>
   | Action<EarnPayload>
   | Action<MarketPayload>
-  | Action<NftPayload>;
+  | Action<NftPayload>
+  | AnyAction;
diff --git a/apps/ledger-live-mobile/src/context/store.ts b/apps/ledger-live-mobile/src/context/store.ts
@@ -1,16 +1,23 @@
 import Config from "react-native-config";
-import { configureStore } from "@reduxjs/toolkit";
+import { configureStore, Tuple } from "@reduxjs/toolkit";
 import reducers from "~/reducers";
 import Rectotron from "~/ReactotronConfig";
+import { assetsDataApi } from "@ledgerhq/live-common/modularDrawer/data/state-manager/api";
 
+// === STORE CONFIGURATION ===
 export const store = configureStore({
   reducer: reducers,
   devTools: !!Config.DEBUG_RNDEBUGGER,
   middleware: getDefaultMiddleware =>
-    getDefaultMiddleware({ serializableCheck: false, immutableCheck: false }),
-  ...(__DEV__ && {
-    enhancers: getDefaultEnhancers => getDefaultEnhancers().concat(Rectotron.createEnhancer()),
-  }),
+    getDefaultMiddleware({ serializableCheck: false, immutableCheck: false }).concat(
+      assetsDataApi.middleware,
+    ),
+
+  enhancers: getDefaultEnhancers =>
+    new Tuple(
+      ...(__DEV__ ? [...getDefaultEnhancers(), Rectotron.createEnhancer()] : []),
+      ...getDefaultEnhancers(),
+    ),
 });
 
 export type StoreType = typeof store;
diff --git a/apps/ledger-live-mobile/src/reducers/index.ts b/apps/ledger-live-mobile/src/reducers/index.ts
@@ -23,6 +23,7 @@ import { ActionsPayload } from "../actions/types";
 import largeMover from "./largeMover";
 import countervalues from "./countervalues";
 import toasts from "./toast";
+import { assetsDataApi } from "@ledgerhq/live-common/modularDrawer/data/state-manager/api";
 
 export type AppStore = Store<State>;
 
@@ -49,6 +50,7 @@ const appReducer = combineReducers({
   modularDrawer,
   largeMover,
   toasts,
+  assetsDataApi: assetsDataApi.reducer,
 });
 
 // TODO: EXPORT ALL POSSIBLE ACTION TYPES AND USE ACTION<TYPES>
diff --git a/apps/ledger-live-mobile/src/reducers/types.ts b/apps/ledger-live-mobile/src/reducers/types.ts
@@ -37,6 +37,7 @@ import { type TabListType as TabPortfolioAssetsType } from "~/screens/Portfolio/
 import { CountervaluesState } from "./countervalues";
 import { ToastState } from "./toast";
 import { ModularDrawerState } from "./modularDrawer";
+import { assetsDataApi } from "@ledgerhq/live-common/modularDrawer/data/state-manager/api";
 
 // === ACCOUNT STATE ===
 
@@ -412,4 +413,5 @@ export type State = {
   modularDrawer: ModularDrawerState;
   largeMover: LargeMoverState;
   toasts: ToastState;
+  assetsDataApi: ReturnType<typeof assetsDataApi.reducer>;
 };
diff --git a/knip.json b/knip.json
@@ -49,7 +49,14 @@
         "src/renderer/mockServiceWorker.js"
       ],
       "ignoreBinaries": ["eslint", "knip", "prettier", "zx", "lint"],
-      "ignoreDependencies": ["prop-types", "allure-commandline", "msw", "buffer", "ws"]
+      "ignoreDependencies": [
+        "prop-types",
+        "allure-commandline",
+        "msw",
+        "buffer",
+        "ws",
+        "@reduxjs/toolkit"
+      ]
     },
     "./apps/ledger-live-mobile": {
       "entry": ["index.js", "src/families/**"],
diff --git a/libs/ledger-live-common/.unimportedrc.json b/libs/ledger-live-common/.unimportedrc.json
@@ -405,11 +405,14 @@
     "src/modularDrawer/utils/getBalanceAndFiatValue.ts",
     "src/modularDrawer/utils/getBalanceAndFiatValueByAssets.ts",
     "src/modularDrawer/utils/groupAccountsByAsset.ts",
-   "src/modularDrawer/utils/parseToBigNumber.ts",
+    "src/modularDrawer/utils/parseToBigNumber.ts",
     "src/modularDrawer/utils/type.ts",
     "src/modularDrawer/utils/calculateProviderTotal.ts",
     "src/modularDrawer/utils/counterValueFormatter.ts",
     "src/modularDrawer/utils/getProviderCurrency.ts",
+    "src/modularDrawer/data/entities/index.ts",
+    "src/modularDrawer/data/state-manager/api.ts",
+    "src/modularDrawer/hooks/useAssetsData.ts",
     "src/notifications/AnnouncementProvider/helpers.ts",
     "src/reactNativeSvg.d.ts",
     "src/rxjs/operators/throwIf.ts",
@@ -420,6 +423,7 @@
     "@ledgerhq/hw-app-eth",
     "@ledgerhq/hw-transport-mocker",
     "@tanstack/react-query",
+    "@reduxjs/toolkit",
     "@types/bchaddrjs",
     "@types/bs58check",
     "@types/pako",
diff --git a/libs/ledger-live-common/package.json b/libs/ledger-live-common/package.json
@@ -192,9 +192,9 @@
     "@ledgerhq/live-network": "workspace:^",
     "@ledgerhq/live-nft": "workspace:^",
     "@ledgerhq/live-promise": "workspace:^",
+    "@ledgerhq/live-signer-canton": "workspace:^",
     "@ledgerhq/live-signer-evm": "workspace:^",
     "@ledgerhq/live-signer-solana": "workspace:^",
-    "@ledgerhq/live-signer-canton": "workspace:^",
     "@ledgerhq/live-wallet": "workspace:^",
     "@ledgerhq/logs": "workspace:^",
     "@ledgerhq/speculos-transport": "workspace:^",
@@ -203,6 +203,7 @@
     "@ledgerhq/wallet-api-core": "^1.21.1",
     "@ledgerhq/wallet-api-exchange-module": "workspace:^",
     "@ledgerhq/wallet-api-server": "^1.10.1",
+    "@reduxjs/toolkit": "2.8.2",
     "@stellar/stellar-sdk": "^11.3.0",
     "@stricahq/typhonjs": "^3.0.0",
     "@taquito/ledger-signer": "^22.0.0",
diff --git a/libs/ledger-live-common/src/modularDrawer/data/entities/index.ts b/libs/ledger-live-common/src/modularDrawer/data/entities/index.ts
diff --git a/libs/ledger-live-common/src/modularDrawer/data/state-manager/api.ts b/libs/ledger-live-common/src/modularDrawer/data/state-manager/api.ts
@@ -21,7 +21,7 @@ export interface AssetsDataWithPagination extends AssetsData {
 
 function transformAssetsResponse(
   response: RawApiResponse,
-  meta: FetchBaseQueryMeta | undefined,
+  meta?: FetchBaseQueryMeta,
 ): AssetsDataWithPagination {
   const enrichedCryptoOrTokenCurrencies = convertApiAssets(response.cryptoOrTokenCurrencies);
 
diff --git a/libs/ledger-live-common/src/modularDrawer/hooks/__test__/useAssetsData.test.ts b/libs/ledger-live-common/src/modularDrawer/hooks/__test__/useAssetsData.test.ts
@@ -1,5 +1,10 @@
+/**
+ * @jest-environment jsdom
+ */
+
 import { renderHook } from "@testing-library/react";
 import { useAssetsData } from "../useAssetsData";
+import { useGetAssetsDataQuery } from "../../data/state-manager/api";
 
 jest.mock("../../data/state-manager/api", () => ({
   useGetAssetsDataQuery: jest.fn(),
@@ -13,7 +18,6 @@ jest.mock("react", () => ({
   useMemo: jest.fn(fn => fn()),
 }));
 
-import { useGetAssetsDataQuery } from "../../data/state-manager/api";
 const mockUseGetAssetsDataQuery = jest.mocked(useGetAssetsDataQuery);
 
 describe("useAssetsData", () => {
diff --git a/libs/ledger-live-common/src/modularDrawer/hooks/useAssetsData.ts b/libs/ledger-live-common/src/modularDrawer/hooks/useAssetsData.ts
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
