🐛 (lld) MAD - Add account - HBAR

.changeset/stale-ways-arrive.md

@@ -0,0 +1,5 @@
+---
+"ledger-live-desktop": minor
+---
+
+MAD Fix Hedera add account

apps/ledger-live-desktop/src/newArch/features/AddAccountDrawer/__tests__/addAccountFlow.test.tsx

@@ -9,7 +9,7 @@ import { openModal } from "~/renderer/actions/modals";
 import { track, trackPage } from "~/renderer/analytics/segment";
 import createStore from "~/renderer/createStore";
 import { State } from "~/renderer/reducers";
-import { ARB_ACCOUNT, BTC_ACCOUNT } from "../../__mocks__/accounts.mock";
+import { ARB_ACCOUNT, BTC_ACCOUNT, HEDERA_ACCOUNT } from "../../__mocks__/accounts.mock";
 import {
   arbitrumCurrency,
   bitcoinCurrency,
@@ -357,4 +357,16 @@ describe("ModularDrawerAddAccountFlowManager", () => {
     expect(screen.getByText("We couldn't add a new Hedera account")).toBeInTheDocument();
     expectTrackPage(3, "cant add new account", { reason: "NO_ASSOCIATED_ACCOUNTS" });
   });
+
+  it("should add a Hedera account when one is scanned", async () => {
+    setup(hederaCurrency);
+
+    await mockScanAccountsSubscription([HEDERA_ACCOUNT]);
+
+    expect(screen.getByText(/we found 1 account/i)).toBeInTheDocument();
+
+    await userEvent.click(screen.getByRole("button", { name: "Confirm" }));
+    expectTrackPage(3, "add account success");
+    expect(screen.getByText(/account added to your portfolio/i)).toBeInTheDocument();
+  });
 });

apps/ledger-live-desktop/src/newArch/features/AddAccountDrawer/screens/ScanAccounts/useScanAccounts.ts

@@ -200,10 +200,7 @@ export function useScanAccounts({
     if (!scanning && !hasImportedAccounts) {
       if (alreadyEmptyAccount && !importableAccounts.length) {
         navigateToWarningScreen(WARNING_REASON.ALREADY_EMPTY_ACCOUNT, alreadyEmptyAccount);
-      } else if (
-        (!creatableAccounts.length || !importableAccounts.length) &&
-        CustomNoAssociatedAccounts
-      ) {
+      } else if (!scannedAccounts.length && CustomNoAssociatedAccounts) {
         navigateToWarningScreen(WARNING_REASON.NO_ASSOCIATED_ACCOUNTS);
       }
     }
@@ -214,6 +211,7 @@ export function useScanAccounts({
     hasImportedAccounts,
     importableAccounts.length,
     navigateToWarningScreen,
+    scannedAccounts.length,
     scanning,
   ]);
 

apps/ledger-live-desktop/src/newArch/features/__mocks__/accounts.mock.ts

@@ -6,6 +6,7 @@ import {
   baseCurrency,
   bitcoinCurrency,
   ethereumCurrency,
+  hederaCurrency,
   scrollCurrency,
 } from "./useSelectAssetFlow.mock";
 
@@ -61,6 +62,10 @@ export const SCROLL_ACCOUNT = genAccount("scroll-1", {
   currency: scrollCurrency,
   operationsSize: 100,
 });
+export const HEDERA_ACCOUNT = genAccount("hedera-1", {
+  currency: hederaCurrency,
+  operationsSize: 100,
+});
 
 export const useCountervaluesPolling = () => ({
   wipe: () => {},