Skip to content

Conversation

LucasWerey
Copy link
Member

@LucasWerey LucasWerey commented Aug 25, 2025

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • MAD - Hbar add account

πŸ“ Description

Fix Hbar add account with MAD. The fix is the same as the one we did on LLM : #9396

An inte test for this specific case has been added to ensure no regression

Demo without any Hbar account:

Screen.Recording.2025-08-25.at.11.19.27.AM.mov

Demo with Hbar account

Screen.Recording.2025-08-25.at.11.20.36.AM.mov

Full Random flow video

Screen.Recording.2025-08-25.at.11.13.17.AM.mov

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Aug 25, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

4 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
ledger-live-github-bot Ignored Ignored Preview Aug 25, 2025 0:29am
native-ui-storybook Ignored Ignored Preview Aug 25, 2025 0:29am
react-ui-storybook Ignored Ignored Preview Aug 25, 2025 0:29am
web-tools Ignored Ignored Preview Aug 25, 2025 0:29am

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Aug 25, 2025
@LucasWerey LucasWerey marked this pull request as ready for review August 25, 2025 09:34
@LucasWerey LucasWerey requested a review from a team as a code owner August 25, 2025 09:34
@LucasWerey LucasWerey merged commit b6b6cd6 into develop Aug 25, 2025
44 of 49 checks passed
@LucasWerey LucasWerey deleted the fix/LIVE-20829 branch August 25, 2025 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants