fix: Use protobuf getters instead of direct access #1714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: litt3 <[email protected]>
Signed-off-by: litt3 <[email protected]>
cody-littley
previously approved these changes
Jul 10, 2025
samlaf
previously approved these changes
Jul 11, 2025
There was a problem hiding this comment.
LGTM. Any idea why TestInterleavedVersions is failing for both sepolia and holesky? We recently increased batch interval 1->5min on sepolia, but not sure why holesky is failing (not sure what its batch interval is either..)
Should we increase their timeout? Or actually we prob want to move them to @cody-littley 's live test framework?
samlaf
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
protogetterlinting rule