Merge remote-tracking branch 'origin/master' into proto-getter

Signed-off-by: litt3 <[email protected]>

Author: litt3

.github/workflows/integration-tests.yml

@@ -76,9 +76,6 @@ jobs:
       - name: Node Plugin
         run: go test -v ./node/plugin/tests
 
-      - name: eigenda-client
-        run: go test -v ./api/clients --testnet-integration
-
       - name: Inabox E2E
         run: make build && cd inabox && make run-e2e
 

.github/workflows/live-network-tests.yaml

@@ -9,7 +9,7 @@ env:
   MISE_VERSION: 2024.12.14
 
 jobs:
-  test:
+  test-v2:
     runs-on: ubuntu-latest
     env:
       LIVE_TESTS: "true"
@@ -31,6 +31,61 @@ jobs:
       - name: Run Live Network Tests
         run: make live-tests
 
+      - name: Notify Slack
+        if: always()
+        run: |
+          if [ "${{ job.status }}" == "success" ]; then
+            COLOR="good"
+            STATUS_EMOJI="✅"
+            MENTION=""
+          else
+            COLOR="danger"
+            STATUS_EMOJI="❌"
+            MENTION="@here "
+          fi
+
+          PAYLOAD=$(jq -n \
+            --arg channel "#da-live-tests" \
+            --arg text "${MENTION}Live Network Tests completed, status: ${STATUS_EMOJI} ${{ job.status }}" \
+            --arg title "logs" \
+            --arg title_link "${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}" \
+            --arg color "$COLOR" \
+            '{
+              channel: $channel,
+              text: $text,
+              attachments: [
+                {
+                  color: $color,
+                  title: $title,
+                  title_link: $title_link
+                }
+              ]
+            }')
+
+          curl -X POST -H "Authorization: Bearer ${{ secrets.DA_TEST_REPORTER_SLACK_OATH_TOKEN }}" \
+               -H 'Content-type: application/json; charset=utf-8' \
+               --data "$PAYLOAD" \
+               https://slack.com/api/chat.postMessage
+
+
+  test-v1:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v4
+
+      - uses: jdx/mise-action@v2
+        with:
+          version: ${{ env.MISE_VERSION }}
+          experimental: true
+      - run: go version
+
+      - name: Install dependencies
+        run: go mod download
+
+      - name: Run live v1 eigenda-client tests
+        run: make live-tests-v1
+
       - name: Notify Slack
         if: always()
         run: |

.gitignore

@@ -1,7 +1,7 @@
 inabox/testdata/*
 inabox/anvil.pid
 
-test/testdata/*
+test/v1/testdata/*
 inabox/resources/kzg/SRSTables/*
 encoding/kzgrs/prover/data/SRSTable/*
 resources/srs/SRSTables/*
@@ -17,8 +17,7 @@ lightnode/docker/args.sh
 .idea
 .env
 .vscode
-.cursor
-.serena
+.claude
 
 icicle/*
 

Makefile

@@ -89,6 +89,8 @@ unit-tests:
 
 live-tests:
 	go test -v ./test/v2/live -v -timeout 60m
+live-tests-v1:
+	go test -v ./api/clients --live-test
 
 fuzz-tests:
 	go test --fuzz=FuzzParseSignatureKMS -fuzztime=5m ./common

api/clients/eigenda_client_e2e_test.go renamed to api/clients/eigenda_client_e2e_live_test.go

@@ -12,46 +12,60 @@ import (
 	"github.com/stretchr/testify/assert"
 )
 
-var runTestnetIntegrationTests bool
+var runTestnetLiveTests bool
+
+const (
+	// Test configuration constants
+	testRPC = "disperser-holesky.eigenda.xyz:443"
+	// TODO: we should use a more reliable RPC provider, injected via secrets
+	testEthRpcUrl                = "https://ethereum-holesky-rpc.publicnode.com"
+	testSignerPrivateKeyHex      = "2d23e142a9e86a9175b9dfa213f20ea01f6c1731e09fa6edf895f70fe279cbb1"
+	testSvcManagerAddr           = "0xD4A7E1Bd8015057293f0D0A557088c286942e84b"
+	testStatusQueryTimeout       = 20 * time.Minute
+	testStatusQueryRetryInterval = 5 * time.Second
+)
 
 func init() {
-	flag.BoolVar(&runTestnetIntegrationTests, "testnet-integration", false, "Run testnet-based integration tests")
+	// Off by default so that this test is not run as part of the unit tests.
+	// To run it, use the flag -live-test when running `go test`.`
+	flag.BoolVar(&runTestnetLiveTests, "live-test", false, "Run live test against holesky testnet")
 }
 
 // TestClientUsingTestnet tests the eigenda client against holesky testnet disperser.
 // We don't test waiting for finality because that adds 12 minutes to the test, and is not necessary
 // because we already test for this in the unit tests using a mock disperser which is much faster.
 func TestClientUsingTestnet(t *testing.T) {
-	if !runTestnetIntegrationTests {
-		t.Skip("Skipping testnet integration test")
+	if !runTestnetLiveTests {
+		t.Skip("Skipping testnet live test")
 	}
 
 	t.Run("PutBlobWaitForConfirmationDepth0AndGetBlob", func(t *testing.T) {
 		t.Parallel()
 
 		client, err := NewEigenDAClient(testutils.GetLogger(), EigenDAClientConfig{
-			RPC: "disperser-holesky.eigenda.xyz:443",
+			RPC: testRPC,
 			// Should need way less than 20 minutes, but we set it to 20 minutes to be safe
 			// In worst case we had 10 min batching interval + some time for the tx to land onchain,
 			// plus wait for 3 blocks of confirmation.
-			StatusQueryTimeout:       20 * time.Minute,
-			StatusQueryRetryInterval: 5 * time.Second,
+			StatusQueryTimeout:       testStatusQueryTimeout,
+			StatusQueryRetryInterval: testStatusQueryRetryInterval,
 			CustomQuorumIDs:          []uint{},
-			SignerPrivateKeyHex:      "2d23e142a9e86a9175b9dfa213f20ea01f6c1731e09fa6edf895f70fe279cbb1",
+			SignerPrivateKeyHex:      testSignerPrivateKeyHex,
 			WaitForFinalization:      false,
 			WaitForConfirmationDepth: 0,
-			SvcManagerAddr:           "0xD4A7E1Bd8015057293f0D0A557088c286942e84b",
-			EthRpcUrl:                "https://1rpc.io/holesky",
+			SvcManagerAddr:           testSvcManagerAddr,
+			EthRpcUrl:                testEthRpcUrl,
 		})
-		data := "hello world!"
 		assert.NoError(t, err)
-		blobInfo, err := client.PutBlob(context.Background(), []byte(data))
+
+		testData := "hello world!"
+		blobInfo, err := client.PutBlob(context.Background(), []byte(testData))
 		assert.NoError(t, err)
 		batchHeaderHash := blobInfo.GetBlobVerificationProof().GetBatchMetadata().GetBatchHeaderHash()
 		blobIndex := blobInfo.GetBlobVerificationProof().GetBlobIndex()
 		blob, err := client.GetBlob(context.Background(), batchHeaderHash, blobIndex)
 		assert.NoError(t, err)
-		assert.Equal(t, data, string(blob))
+		assert.Equal(t, testData, string(blob))
 	})
 
 	t.Run("PutBlobWaitForConfirmationDepth3AndGetBlob", func(t *testing.T) {