fix: Update disperser client to take in logger vs initializing default one for ntp clock

[ethenotethan]

Currently debug logs are always being presented in proxy for NTP clock synchronization updates. This should instead use a preconfigured logger passed through via dependency injection

Why are these changes needed?

Checks

• I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
• I've checked the new test coverage and the coverage percentage didn't drop.
• Testing Strategy
  • Unit tests
  • Integration tests
  • This PR is not tested :(

[Copilot]

Pull Request Overview

This PR refactors the Disperser client to accept an external logger instead of creating its own, and updates all call sites (tests, examples, and integration setup) to pass in a logger.

• Change signature of NewDisperserClient to take a logging.Logger
• Update tests and integration code to construct and pass a common.NewLogger
• Adjust example usage in client_construction.go to include a logger parameter

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
test/v2/correctness/correctness_test.go	Added import of common, instantiated logger, and passed it into NewDisperserClient
test/v2/client/test_client.go	Propagated logger to NewDisperserClient in test client setup
inabox/tests/integration_suite_test.go	Updated integration setup to pass logger into the new client constructor
api/clients/v2/examples/client_construction.go	Modified example to call createDisperserClient(logger, …), updated its signature
api/clients/v2/disperser_client.go	Changed NewDisperserClient signature, removed internal logger init, wired logger.With into NTP clock

Comments suppressed due to low confidence (2)

api/clients/v2/examples/client_construction.go:50

• The variable logger is undefined in createPayloadDisperser. Either initialize a logger before calling createDisperserClient or change createPayloadDisperser to accept a logger parameter.

disperserClient, err := createDisperserClient(logger, privateKey, kzgProver)

api/clients/v2/disperser_client.go:88

• [nitpick] Consider validating that the provided logger is non-nil at the start of the constructor to fail fast and avoid panics when calling logger.With later.

func NewDisperserClient(logger logging.Logger, config *DisperserClientConfig, signer corev2.BlobRequestSigner, prover encoding.Prover, accountant *Accountant) (*disperserClient, error) {