Skip to content

Conversation

hopeyen
Copy link
Contributor

@hopeyen hopeyen commented May 15, 2025

Why are these changes needed?

https://eigenlabs.slack.com/archives/C06JZQHN5R7/p1747232104149929

reduce the flakiness of tests by removing NTP requirement

Checks

  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@hopeyen hopeyen marked this pull request as ready for review May 15, 2025 14:32
@hopeyen hopeyen merged commit 00256fd into master May 15, 2025
16 checks passed
@hopeyen hopeyen deleted the hope/ntp-init branch May 15, 2025 18:52
samlaf added a commit that referenced this pull request Jul 12, 2025
samlaf added a commit that referenced this pull request Jul 16, 2025
* Revert "fix: Update disperser client to take in logger vs initializing default one for ntp clock (#1651)"

This reverts commit 7f93aea.

* Revert "refactor: ntp init logs but not panic (#1568)"

This reverts commit 00256fd.

* Revert "feat: validator/disperser clock synchrony (#1509)"

This reverts commit 5c19ace.

* fix: NewDispserserClient call

Remove no longer needed log first argument

* chore: go mod tidy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants