Skip to content

Conversation

@Boris-c
Copy link
Contributor

@Boris-c Boris-c commented Jun 28, 2025

Change log level of external extension error stack from debug to error.

-> Makes it easier to debug.
-> Makes it easier for end users to report the stack when filing a bug report.

@Nerivec
Copy link
Collaborator

Nerivec commented Jun 29, 2025

Debug stacks should not be error.

@Nerivec
Copy link
Collaborator

Nerivec commented Jul 1, 2025

I suggest we add the (error as Error).message to the end of the above logging line (the already error one) and keep the error stack debug.
That should keep it in line with the rest of the code.

Change log level of external extension error stack from debug to error.

-> Makes it easier to debug.
-> Makes it easier for end users to report the stack when filing a bug report.
@Nerivec Nerivec changed the title Update externalJS.ts fix: log error message when external JS fails to load Jul 11, 2025
@Koenkk Koenkk merged commit f4d821d into Koenkk:dev Jul 11, 2025
11 checks passed
@Koenkk
Copy link
Owner

Koenkk commented Jul 11, 2025

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants