Skip to content

Commit f4d821d

Browse files
authored
fix: log error message when external JS fails to load (#27837)
1 parent c465ef8 commit f4d821d

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

lib/extension/externalJS.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@ export default abstract class ExternalJSExtension<M> extends Extension {
193193
fs.renameSync(filePath, `${filePath}.invalid`);
194194

195195
logger.error(
196-
`Invalid external ${this.mqttTopic} '${extension.name}' was ignored and renamed to prevent interference with Zigbee2MQTT.`,
196+
`Invalid external ${this.mqttTopic} '${extension.name}' was ignored and renamed to prevent interference with Zigbee2MQTT. (${(error as Error).message})`,
197197
);
198198
// biome-ignore lint/style/noNonNullAssertion: always Error
199199
logger.debug((error as Error).stack!);

test/extensions/externalConverters.test.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -348,6 +348,7 @@ describe("Extension: ExternalConverters", () => {
348348
);
349349
expect(fs.existsSync(filepath)).toStrictEqual(false);
350350
expect(fs.existsSync(path.join(mockBasePath, "invalid.mjs.invalid"))).toStrictEqual(true);
351+
expect(mockLogger.error).toHaveBeenCalledWith(expect.stringContaining("Parse failure: Expected ';', '}' or <eof>"));
351352
});
352353
});
353354

0 commit comments

Comments
 (0)