Skip to content

Conversation

pankgeorg
Copy link
Collaborator

@pankgeorg pankgeorg commented Feb 2, 2024

Alternative to #4862, includes #4863

Replaces the download from CDN/scratchspace with an artifact

@fonsp
Copy link
Collaborator

fonsp commented Feb 8, 2024

The advantage of this PR over #4862 is that this PR will always have access to the plotly.min.js asset, while #4862 only works when PlotlyJS is loaded by the user, right?

@pankgeorg
Copy link
Collaborator Author

The advantage of this PR over #4862 is that this PR will always have access to the plotly.min.js asset, while #4862 only works when PlotlyJS is loaded by the user, right?

Yes, exactly. We also directly link to the Plotly release assets, which is also the disadvantage of this PR (the artifact being 110MB)

@disberd
Copy link
Member

disberd commented Mar 20, 2024

@pankgeorg I created a repository last week to experiment with javascript and bundling that might be relevant for this.
The repo is at https://github.com/disberd/PlotlyArtifactsESM and it automatically bundles and release in an artifact ready format the plotly library.
If you are still pursuing this you might have a look at it and let me know if it can be used or if you see issues with its implementation.

I am planning on using this in PlutoPlotly for the next release

@BeastyBlacksmith
Copy link
Member

now that PlotlyKaleido hosts these as Artifacts anyway (JuliaPlots/PlotlyKaleido.jl#27) we might be able to use these?

@fonsp fonsp mentioned this pull request May 5, 2025
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants