Skip to content

Conversation

mbauman
Copy link
Contributor

@mbauman mbauman commented Mar 19, 2025

There are three parts to this pull request, and this can easily be split apart if that's preferred.


There are two paths forward here, and I'm happy to help make either happen:

  • merge this PR as is, and then an owner here triggers the plotly and mathjax release builds (and subsequent PRs) to move update the Artifact.toml to use those official releases.
  • I can split this to just contain f9ffcb0, then an owner here can trigger the actions, then merge the auto-generated PRs, then I can submit f41323d.

Fixes #26.

@mbauman mbauman changed the title Setup Javascript resources to use released artifacts Setup Javascript resources to use released artifacts by default Mar 19, 2025
@BeastyBlacksmith
Copy link
Member

Thank you for investing the time to set this up. I would be fine to merge it as is and trigger the action.

Should we keep using the artifacts already present on your fork or use the then generated ones here?

@mbauman
Copy link
Contributor Author

mbauman commented Mar 19, 2025

Personally, I think it looks much more professional to use releases on the proper repo in the proper org. I think it's worth doing. The reason I got up to a 2.35.2 +2 on my plotly release version was just to test out the +buildsuffix support. I'm also liable to accidentally delete a fork after forgetting that we're doing this.

@BeastyBlacksmith
Copy link
Member

Personally, I think it looks much more professional to use releases on the proper repo in the proper org.

We do that then

@BeastyBlacksmith BeastyBlacksmith merged commit 7829287 into JuliaPlots:main Mar 21, 2025
4 of 6 checks passed
@BeastyBlacksmith
Copy link
Member

One thing I noticed is, that if you trigger both artifact builds the pull-requests will overwrite each other instead of either opening two PRs or create a PR with both updates (#28)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Failed to serialize document: Uncaught" when offline
2 participants