-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Initialize search bar auto-completion with real database context (no tab switch needed) #13816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Siedlerchr
merged 7 commits into
JabRef:main
from
harii55:fix/11428-searchbar-autocomplete
Sep 4, 2025
Merged
Initialize search bar auto-completion with real database context (no tab switch needed) #13816
Siedlerchr
merged 7 commits into
JabRef:main
from
harii55:fix/11428-searchbar-autocomplete
Sep 4, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tab switch needed)
subhramit
previously requested changes
Sep 3, 2025
Co-authored-by: Subhramit Basu <[email protected]>
subhramit
reviewed
Sep 3, 2025
@trag-bot didn't find any issues in the code! ✅✨ |
calixtus
approved these changes
Sep 4, 2025
Siedlerchr
approved these changes
Sep 4, 2025
Nice! Clean code, quick fix. Love it. |
2 tasks
Siedlerchr
added a commit
that referenced
this pull request
Sep 8, 2025
* upstream/main: (54 commits) Split relativizeSymlinks parameterized tests in separate tests (#13782) Update the search syntax highlight for web search (#13801) Chore(deps): Bump ai.djl:bom from 0.33.0 to 0.34.0 in /versions (#13833) Fix typos in CHANGELOG.md (#13826) Chore(deps): Bump com.konghq:unirest-modules-gson in /versions (#13831) Chore(deps): Bump org.gradlex:extra-java-module-info in /build-logic (#13830) Chore(deps): Bump org.apache.logging.log4j:log4j-to-slf4j in /versions (#13832) Chore(deps): Bump io.zonky.test.postgres:embedded-postgres-binaries-bom (#13834) Chore(deps): Bump jablib/src/main/resources/csl-locales (#13829) Chore(deps): Bump jablib/src/main/resources/csl-styles (#13827) Chore(deps): Bump jablib/src/main/abbrv.jabref.org (#13828) add: CAYW endpoint formats (#13785) New Crowdin updates (#13823) chore(deps): update dependency org.kohsuke:github-api to v2.0-rc.5 (#13822) Add support for automatic ICORE conference ranking lookup [#13476] (#13699) New Crowdin updates (#13820) Initialize search bar auto-completion with real database context (no tab switch needed) (#13816) Fixes #13274: Allow cygwin-paths on Windows (#13297) Refine "REDACTED" replacement of API key value in web fetcher search URL (#13814) changed ISSNCleanup into NormalizeIssn, refactored respective tests #13748 (#13767) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11428
This PR ensures that the search bar's auto-completion is correctly initialized as soon as a database is opened, without requiring the user to switch tabs. The auto-completer is now updated immediately after the real database context is loaded, improving the user experience and resolving the issue where auto-completion was unavailable until a tab switch.
Steps to test
jablib/src/main/resources/Chocolate.bib
.s
orsm
.Before
No suggestions appear at this step.
After
Auto-completion popup appears immediately.
Mandatory checks
CHANGELOG.md
in a way that is understandable for the average user (if change is visible to the user)