Update the search syntax highlight for web search #13801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sed parser syntax
![trag-bot[bot]](https://avatars.githubusercontent.com/in/856808?s=60&v=4){kind=small}
| int line = offendingToken.getLine(); | ||
| int charPositionInLine = offendingToken.getCharPositionInLine() + 1; | ||
|
|
||
| String errorMessage = "Invalid syntax at line %d, position %d".formatted(line, charPositionInLine); |
There was a problem hiding this comment.
The error message string is not using sentence case as required for UI text. It should start with a capital letter and maintain consistent casing with other UI messages.
| @@ -85,18 +87,31 @@ public WebSearchPaneViewModel(GuiPreferences preferences, DialogService dialogSe | |||
| } | |||
|
|
|||
| try { | |||
| parser.parse(queryText, NO_EXPLICIT_FIELD); | |||
| SearchLexer lexer = new SearchLexer(CharStreams.fromString(queryText)); | |||
| lexer.removeErrorListeners(); // no infos on file system | |||
There was a problem hiding this comment.
Comment provides no additional information beyond what is obvious from the code itself. Such trivial comments should be removed according to the commenting guidelines.
…for validity of DOI
…ebsearchsyntaxhighlight
Siedlerchr
reviewed
Sep 6, 2025
| int charPositionInLine = offendingToken.getCharPositionInLine() + 1; | ||
|
|
||
| String errorMessage = "Invalid syntax at line %d, position %d".formatted(line, charPositionInLine); | ||
| return ValidationMessage.error(Localization.lang(errorMessage)); |
There was a problem hiding this comment.
Please reuse the existing l10n: Localization.lang("Invalid query element '%0' at position %1,line, charPositioninLIne)...
koppor
approved these changes
Sep 8, 2025
| @Test | ||
| void queryConsistingOfInvalidDOIIsValid() { | ||
| viewModel.queryProperty().setValue("101.1007/JHEP02(2023)082"); | ||
| // There is currently no interpretation of nearly-valid identifiers, therefore, this is concidered as "regular" search term |
There was a problem hiding this comment.
Misspelled word in comment ('concidered' should be 'considered'). Variable names and comments should be correctly spelled to maintain code quality.
| viewModel.queryProperty().setValue("101.1007/JHEP02(2023)082"); | ||
| assertFalse(viewModel.queryValidationStatus().validProperty().getValue()); | ||
| // There is currently no interpretation of nearly-valid identifiers, therefore, this is concidered as "regular" search term |
There was a problem hiding this comment.
The comment merely restates what the code does and contains a spelling error ('concidered'). Comments should provide additional information not obvious from the code.
Siedlerchr
approved these changes
Sep 8, 2025
Siedlerchr
added a commit
that referenced
this pull request
Sep 8, 2025
* upstream/main: (54 commits) Split relativizeSymlinks parameterized tests in separate tests (#13782) Update the search syntax highlight for web search (#13801) Chore(deps): Bump ai.djl:bom from 0.33.0 to 0.34.0 in /versions (#13833) Fix typos in CHANGELOG.md (#13826) Chore(deps): Bump com.konghq:unirest-modules-gson in /versions (#13831) Chore(deps): Bump org.gradlex:extra-java-module-info in /build-logic (#13830) Chore(deps): Bump org.apache.logging.log4j:log4j-to-slf4j in /versions (#13832) Chore(deps): Bump io.zonky.test.postgres:embedded-postgres-binaries-bom (#13834) Chore(deps): Bump jablib/src/main/resources/csl-locales (#13829) Chore(deps): Bump jablib/src/main/resources/csl-styles (#13827) Chore(deps): Bump jablib/src/main/abbrv.jabref.org (#13828) add: CAYW endpoint formats (#13785) New Crowdin updates (#13823) chore(deps): update dependency org.kohsuke:github-api to v2.0-rc.5 (#13822) Add support for automatic ICORE conference ranking lookup [#13476] (#13699) New Crowdin updates (#13820) Initialize search bar auto-completion with real database context (no tab switch needed) (#13816) Fixes #13274: Allow cygwin-paths on Windows (#13297) Refine "REDACTED" replacement of API key value in web fetcher search URL (#13814) changed ISSNCleanup into NormalizeIssn, refactored respective tests #13748 (#13767) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #13691
Updated the websearch field to be highlighted in accordance with the ANTLR based parser, rather than the old lucene one.
Steps to test
Writing a query to the web search field should turn it red if the query doesn't obey the search syntax rules.
Mandatory checks
CHANGELOG.mdin a way that is understandable for the average user (if change is visible to the user)