feat: Update WebSearchTab #13791
Merged
feat: Update WebSearchTab #13791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sidenote: BiodiversityHiertage tester seems to be broke and just say successful regardless of whatever you put... |
![trag-bot[bot]](https://avatars.githubusercontent.com/in/856808?s=60&v=4){kind=small}
jabgui/src/main/java/org/jabref/gui/preferences/websearch/ApiKeyDialog.java
Outdated
Show resolved
Hide resolved
3 tasks
subhramit
reviewed
Aug 30, 2025
CHANGELOG.md
Outdated
| @@ -83,6 +83,7 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv | |||
| - The Welcome tab now has a responsive layout. [#12664](https://github.com/JabRef/jabref/issues/12664) | |||
| - We introduced a donation prompt in the Welcome tab. [#12664](https://github.com/JabRef/jabref/issues/12664) | |||
| - We changed to syntax for the websearch to the one of the main search bar. [#13607](https://github.com/JabRef/jabref/issues/13607) | |||
| - We improved the for the web search tab in the preferences dialog and the event viewer for debugging. | |||
There was a problem hiding this comment.
Two unrelated things which do not seem very minor adjustments (like the add button) - so each deserve their own entry.
subhramit
reviewed
Aug 30, 2025
jabgui/src/main/java/org/jabref/gui/preferences/websearch/ApiKeyDialog.java
Outdated
Show resolved
Hide resolved
subhramit
reviewed
Aug 30, 2025
jabgui/src/main/java/org/jabref/gui/preferences/websearch/WebSearchTabViewModel.java
Outdated
Show resolved
Hide resolved
subhramit
reviewed
Aug 30, 2025
jabgui/src/main/java/org/jabref/gui/preferences/websearch/WebSearchTabViewModel.java
Outdated
Show resolved
Hide resolved
subhramit
reviewed
Aug 30, 2025
jabgui/src/main/java/org/jabref/gui/preferences/websearch/WebSearchTabViewModel.java
Outdated
Show resolved
Hide resolved
jabgui/src/main/java/org/jabref/gui/preferences/websearch/ApiKeyDialog.java
Show resolved
Hide resolved
calixtus
previously approved these changes
Sep 1, 2025
subhramit
previously approved these changes
Sep 1, 2025
calixtus
previously approved these changes
Sep 1, 2025
subhramit
approved these changes
Sep 1, 2025
|
@trag-bot didn't find any issues in the code! ✅✨ |
2 similar comments
|
@trag-bot didn't find any issues in the code! ✅✨ |
|
@trag-bot didn't find any issues in the code! ✅✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/JabRef/jabref-issue-melting-pot/issues/785
Steps to test
Open preferences then web search tab. The WebSearchTab is now optimized to remove the nested scrolling behavior and uses a more intuitive interface when configuring online fetcher catalog.
demo.mp4
Mandatory checks
CHANGELOG.mdin a way that is understandable for the average user (if change is visible to the user)