-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
feat(gui): Better looking error console #13783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can you link the specific sub-task @Yubo-Cao |
Thoughts: This will definitely help in debugging |
So in previous versions users could not see "Unsupported JavaFX configuration"? I would leave everything. Though.. maybe we can add a combobox for filtering (>=) log levels? |
I didn't change the error console logic at all. I figured perhaps ... I messed up my JavaFX environment? I probably should have linked this issue instead: https://github.com/JabRef/jabref-issue-melting-pot/issues/782 |
Ah, my confusion stemmed from not opening the event log since a long time, sorry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just check once if the javafx configuration thing appears on main as well
The unsupported javafx config comes from merging modules together. This is a known issue. |
* upstream/main: Fix/theme manager (JabRef#13764) Hotfix: Remove obsolete language keys
0ce4c88
to
e8b35d8
Compare
Hey, we noticed that you force-pushed your changes. Force pushing is a bad practice when working together on a project (mainly because it is not supported well by GitHub itself). Commits are lost and comments on commits lose their context, thus making it harder to review changes. When the pull request is getting integrated into In future, please avoid that. For now, you can continue working. |
You could add a link to the issue tracker, if you say that an issue could be reported in the intro text. But how ever, I think the info text belongs into the documentation and not into the ui. |
@trag-bot didn't find any issues in the code! ✅✨ |
We forgot to add a changelog entry for this |
I conveniently updated the CHANEGLOG at another open PR that would get this fixed after merged... #13791 |
Closes https://github.com/JabRef/jabref-issue-melting-pot/issues/782
Steps to test
Open Help > View Event Log
Mandatory checks
CHANGELOG.md
in a way that is understandable for the average user (if change is visible to the user)