Transaction tests

.travis.yml

@@ -14,7 +14,7 @@ before_install:
 
 script:
   - cp config/example.settings.yml config/settings.dev.yml
-  - php vendor/bin/phpunit --group UnitTest --coverage-clover=coverage.xml
+  - php vendor/bin/phpunit --group UnitTest 
   - php vendor/bin/phpcs --standard=PSR2 src test
 
 notifications:

phpunit.xml.dist

@@ -1,9 +1,20 @@
 <?xml version="1.0" encoding="utf-8"?>
-<phpunit bootstrap="./test/bootstrap.php"
-    colors="true">
+<phpunit bootstrap="./test/bootstrap.php" colors="true">
     <testsuites>
         <testsuite name="Crayfish">
             <directory>test</directory>
         </testsuite>
     </testsuites>
-</phpunit>
+    <filter>
+      <whitelist processUncoveredFilesFromWhitelist="true">
+        <directory suffix=".php">src</directory>
+        <exclude>
+          <file>src/index.php</file>
+          <file>src/app.php</file>
+        </exclude>
+      </whitelist>
+    </filter>
+    <logging>
+      <log type="coverage-clover" target="coverage.xml"/>
+    </logging>
+</phpunit>

src/Provider/CrayfishProvider.php

@@ -133,12 +133,7 @@ function ($id) use ($app) {
                 // Run only if $id given /can also be refering root resource,
                 // we accept only UUID V4 or empty
                 if (null != $id) {
-                    $sparql_query = $app['twig']->render(
-                        'getResourceByUUIDfromTS.sparql',
-                        array(
-                            'uuid' => $id,
-                        )
-                    );
+                    $sparql_query = $app['twig']->render('getResourceByUUIDfromTS.sparql', array('uuid' => $id));
                     try {
                         $sparql_result = $app['triplestore']->query($sparql_query);
                     } catch (\Exception $e) {
@@ -162,12 +157,19 @@ function ($id) use ($app) {
 
     }
 
+    /**
+     * Inherits from ServiceProviderInterface
+     *
+     * @codeCoverageIgnore
+     */
     public function boot(Application $app)
     {
     }
 
     /**
      * Part of ControllerProviderInterface
+     *
+     * @codeCoverageIgnore
      */
     public function connect(Application $app)
     {
@@ -212,15 +214,16 @@ public function connect(Application $app)
             ->value('child', "")
             ->before(
                 function (Request $request) {
-                    if (isset($request->attributes->parameters) && $request->attributes->parameters->has('id')) {
+                    if (isset($request->attributes) && $request->attributes->has('id')) {
                         // To get this to work we need to GET /islandora/resource//tx:id
                         // So we move the $id to the $child parameter.
-                        $id = $request->attributes->parameters->get('id');
-                        $request->attributes->parameters->set('child', $id);
-                        $request->attributes->parameters->set('id', '');
+                        $id = $request->attributes->get('id');
+                        $request->attributes->set('child', $id);
+                        $request->attributes->set('id', '');
                     }
                 }
             )
+            ->convert('id', $app['islandora.idToUri'])
         ->bind('islandora.transactionGet');
 
         $controllers->post("/transaction", "islandora.transactioncontroller:create")