Skip to content

Conversation

whikloj
Copy link
Member

@whikloj whikloj commented Jun 9, 2016

Partially addresses Islandora/documentation#283

@codecov-io
Copy link

codecov-io commented Jun 9, 2016

Current coverage is 61.02%

Merging #10 into master will increase coverage by 36.02%

@@             master        #10   diff @@
==========================================
  Files             4          4          
  Lines           236        195    -41   
  Methods          12         15     +3   
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits             59        119    +60   
+ Misses          177         76   -101   
  Partials          0          0          

Powered by Codecov. Last updated by 87d7979...8ae645f

@ruebot
Copy link
Member

ruebot commented Jun 9, 2016

@whikloj you good with me merging this? Or do you want to chip away and add to it?

@whikloj
Copy link
Member Author

whikloj commented Jun 9, 2016

@ruebot maybe leave it for now.
I was reading a good article on unit testing and TDD, and so I am trying not to write tests just for the coverage number.

@whikloj
Copy link
Member Author

whikloj commented Jun 15, 2016

@ruebot @DiegoPino
Let's commit this if you're happy.

I had a discussion with a developer (who may or may not be @zozlak) and they are going to continue on with Islandora/documentation#283

@ruebot ruebot merged commit 2b595d0 into Islandora:master Jun 15, 2016
@zozlak
Copy link

zozlak commented Jun 23, 2016

Yes, that's me.

I spent the last week trying to convincing my bosses to use Islandora CLAW but finally succeeded.

Now I am going on holidays for one week and after that I should be able to do something useful.

Many thanks for your work!

@ruebot
Copy link
Member

ruebot commented Jun 23, 2016

@zozlak that's great! Looking forward to working with you!

@whikloj whikloj deleted the transaction-tests branch September 12, 2022 14:58
rosiel pushed a commit to rosiel/Crayfish that referenced this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants