Skip to content

Conversation

windreamer
Copy link
Collaborator

@windreamer windreamer commented Jul 24, 2025

Motivation

Fix bug due to too strict version regex, to support more version scheme like post-release version.

Checklist

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  • If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  • The documentation has been modified accordingly, like docstring or example tutorials.

@lvhan028 lvhan028 requested a review from RunningLeon July 24, 2025 07:28
Copy link
Collaborator

@RunningLeon RunningLeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lvhan028
Copy link
Collaborator

I found the built package after #3726 is significantly smaller than previous versions due to the absence of the -DCMAKE_BUILD_TYPE=RelWithDebInfo compilation option.
Could we re-enable the -DCMAKE_BUILD_TYPE=RelWithDebInfo option? Without debug symbols, it becomes difficult to investigate user-reported issues with the TurboMind engine.

@windreamer
Copy link
Collaborator Author

I found the built package after #3726 is significantly smaller than previous versions due to the absence of the -DCMAKE_BUILD_TYPE=RelWithDebInfo compilation option. Could we re-enable the -DCMAKE_BUILD_TYPE=RelWithDebInfo option? Without debug symbols, it becomes difficult to investigate user-reported issues with the TurboMind engine.

Done

@windreamer windreamer requested a review from lvhan028 July 24, 2025 12:44
@lvhan028 lvhan028 merged commit a731a7f into InternLM:main Jul 25, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants