-
Notifications
You must be signed in to change notification settings - Fork 609
feat(build): Integrate and build turbomind backend directly in setup.py #3726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
25304ea
to
4f0004d
Compare
2dc538b
to
5bbcbf6
Compare
be6c1a6
to
1d27ee7
Compare
efe4393
to
b4f23bb
Compare
The end of line sequence of cmake/yaml-cpp_cmake_policy.patch is CRLF, which may cause failures when applying a git patch on Windows When I compile, I encounter this error, but it probably isn't caused by this pull request since the windows ci run success. It should be an issue with my environment. However, adding this compilation flag for MSVC can fix the error.
![]() |
I ran into this issue as well. Here's what happened:
I’m not sure if this is the best solution, and I’m open to suggestions. |
a4de152
to
e818a9e
Compare
Tested on windows and found a git related issue. Setting
|
Yes, already fixed in ci. |
e5bc5f5
to
29e953e
Compare
29e953e
to
d6c5558
Compare
d6c5558
to
2dc9245
Compare
Motivation
Currently, the
tubomind
backend inlmdeploy
requires a separatecmake
build process and packaging before being included in thelmdeploy
wheel package. Furthermore, a direct installation of thelmdeploy
source package does not install thetubomind
backend. This PR aims to simplify this process by leveragingcmake-build-extension
to directly build and package thetubomind
backend within thesetup.py
script, streamlining the build and installation process for users.Modification
This PR integrates
cmake-build-extension
into thesetup.py
file. This allows us to directly callcmake
during thesetup.py
execution to compile and package thetubomind
backend. This eliminates the need for a separate build and packaging step, and ensures that thetubomind
backend is installed whenlmdeploy
is installed, either from source or from a wheel.Use cases
lmdeploy
and itstubomind
backend with a single command:pip install lmdeploy
.lmdeploy
andtubomind
more easily without having to manage separate build processes.tubomind
backend is always installed whenlmdeploy
is installed, preventing potential runtime errors due to missing dependencies.Checklist