Fix: undo hardcoded activity indicator color #342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flochtililoch
approved these changes
Aug 13, 2021
Collaborator
flochtililoch
left a comment
flochtililoch
left a comment
There was a problem hiding this comment.
Would be good if we could use the values from the Colors service instead of hard coded values. Looks good otherwise, thanks for the fix!
ratneshpkn
force-pushed
the
ashwinibm/fix-undo-hardcoded-activity-indicator-color
branch
from
3ae225b to
ab81a42
Compare
Contributor
Author
|
@flochtililoch I'm merging this since |
flochtililoch
deleted the
ashwinibm/fix-undo-hardcoded-activity-indicator-color
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Undoing the change in #275 since we wrote a patch in the client app instead.
Ref 1
Context:
React Native 0.63 does not have a default color for ActivityIndicator on Android. See reference for creating a patch on the client app.