Skip to content

Conversation

@ashwinibm
Copy link
Contributor

Apply default color for other ActivityIndicators

Reference:
#275
https://github.com/Instawork/instawork/pull/13363/files#r667629321

@ashwinibm ashwinibm requested a review from flochtililoch July 12, 2021 05:14
Copy link
Contributor

@adamstep adamstep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is Instawork's default color. It shouldn't be hard-coded in HV.

@adamstep
Copy link
Contributor

Can we use the default color per-platform? Is that what the RN spinner does by default?

@flochtililoch
Copy link
Collaborator

The version of RN we're using has a bug that prevents Android from using the default color on spinners. We've already taken the step to hardcode our color in #275, but that might not be the most elegant solution. Maybe we can undo #275 and instead write a patch for our RN app, so that default color is not ignored on Android.

@adamstep
Copy link
Contributor

I'm ok hard-coding the defaults in HV. But ideally we can work around the RN bug by hard-coding the original default color.

@ashwinibm
Copy link
Contributor Author

Closing in favor of using a patch in the client app instead https://github.com/Instawork/mobile/pull/3848

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants