Skip to content

fix: OPTIC-1087: Label Config Preview not handling editor lifecycle correctly for updates #6381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 18, 2024
Merged

fix: OPTIC-1087: Label Config Preview not handling editor lifecycle correctly for updates #6381

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
541ae2c
fix: OPTIC-1087: Label Config Preview not handling editor lifecycle c…
bmartel Sep 13, 2024
0ae42ce
ensure onPresignUrlForProject is stable
bmartel Sep 13, 2024
59cc4cf
Apply suggestions from code review
bmartel Sep 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 18 additions & 13 deletions web/apps/labelstudio/src/pages/CreateProject/Config/Preview.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,11 @@ export const Preview = ({ config, data, error, loading, project }) => {
const lsf = useRef(null);
const resolvingEditor = useMemo(loadDependencies);
const rootRef = useRef();
const projectRef = useRef(project);
const api = useAPI();

projectRef.current = project;

const currentTask = useMemo(() => {
return {
id: 1,
Expand All @@ -37,7 +40,7 @@ export const Preview = ({ config, data, error, loading, project }) => {
// return same url if http(s)
if (["http:", "https:"].includes(parsedUrl.protocol)) return url;

const projectId = project.id;
const projectId = projectRef.current.id;

const fileuri = btoa(url);

Expand Down Expand Up @@ -101,18 +104,7 @@ export const Preview = ({ config, data, error, loading, project }) => {
lsf.current = ls;
});
}

return () => {
if (lsf.current) {
console.info("Destroying LSF");
// there is can be weird error from LSF, but we can just skip it for now
try {
lsf.current.destroy();
} catch (e) {}
lsf.current = null;
}
};
}, [initLabelStudio, currentConfig, currentTask]);
}, [currentConfig, currentTask]);

useEffect(() => {
if (lsf.current?.store) {
Expand All @@ -138,6 +130,19 @@ export const Preview = ({ config, data, error, loading, project }) => {
}
}, [currentTask]);

useEffect(() => {
return () => {
if (lsf.current) {
console.info("Destroying LSF");
// there can be weird error from LSF, but we can just skip it for now
try {
lsf.current.destroy();
} catch (e) {}
lsf.current = null;
}
};
}, []);

return (
<div className={configClass.elem("preview")}>
<h3>UI Preview</h3>
Expand Down
Loading