-
Notifications
You must be signed in to change notification settings - Fork 3.1k
fix: OPTIC-1087: Label Config Preview not handling editor lifecycle correctly for updates #6381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…orrectly for updates
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for heartex-docs canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⌛ 3 days left in your free trial, upgrade for $20/seat/month or contact us.
|
@ellipsis-dev review this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Reviewed everything up to 0ae42ce in 28 seconds
More details
- Looked at
78lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_aHA3Ow9TwsZcmzC6
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
⌛ 3 days left in your free trial, upgrade for $20/seat/month or contact us.
PR fulfills these requirements
[fix|feat|ci|chore|doc]: TICKET-ID: Short description of change madeex.fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errorsChange has impacts in these area(s)
(check all that apply)
Describe the reason for change
When changing values in the Labelling Config via the live editor, the correct lifecycle methods were not firing on update and there would be a missed step to clear out shared stores on the current instance. It would then proceed to try and create another AnnotationStore again, and end up with a case where the shared store had a reference in the module scoped Stores and StoreIds Map(s), but the local instance of the mobx model did not, and would try to re-register the exact copy once again which was failing. Once failed, this error would propagate across navigations to the next time a task would attempt to be loaded and would fail to load a task with a Taxonomy tag, only clearing up on a refresh of the browser.
Which logical domain(s) does this change affect?
Config Preview, Taxonomy
fix: OPTIC-1087: Correct Label Studio lifecycle in Config Preview
Summary:
Fixes lifecycle handling of Label Studio in
Preview.jsxto prevent errors in the live editor.Key points:
Preview.jsx.useEffectwith an empty dependency array.Generated with ❤️ by ellipsis.dev