Move textual functions in data_model_utils.tabular to data_model_utils.textual #505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to data_model_utils.textual and deprecated them in data_model_utils.tabular (fix HazyResearch#503)
Codecov Report
@@ Coverage Diff @@
## master #505 +/- ##
==========================================
+ Coverage 85.80% 85.83% +0.03%
==========================================
Files 88 88
Lines 4571 4583 +12
Branches 855 855
==========================================
+ Hits 3922 3934 +12
Misses 464 464
Partials 185 185
Flags with carried forward coverage won't be shown. Click here to find out more.
|
HiromuHota
changed the title
lukehsiao
approved these changes
Sep 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the problems or issues
Is your pull request related to a problem? Please describe.
See #503.
Does your pull request fix any issue.
Fix #503.
Description of the proposed changes
Copy textual functions in
data_model_utils.tabulartodata_model_utils.textual, and deprecated them in data_model_utils.tabular.Test plan
A clear and concise description of how you test the new changes.
Checklist