Skip to content

get_sentence_ngrams, get_neighbor_sentence_ngrams, same_sentence should be fonduer.utils.data_model_utils.textual? #503

@HiromuHota

Description

@HiromuHota

Description of the bug

get_sentence_ngrams, get_neighbor_sentence_ngrams, same_sentence are placed under fonduer.utils.data_model_utils.tabular module, but their names sound and their behaviours look textual.

To Reproduce

Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Execute the code '...'
    If necessary, attach example data which can be used to replicate the issue.

Expected behavior

Move them into fonduer.utils.data_model_utils.textual?

Error Logs/Screenshots

If applicable, add error logs or screenshots to help explain your problem.

Environment (please complete the following information)

  • Fonduer Version: 0.8.2

Additional context

Add any other context about the problem here.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions