Skip to content

Conversation

@kaspermarkus
Copy link
Member

This branch is compatible with the advanced MM branch GPII-1230 of universal (GPII/universal#507). It contains the (relevant) code from Josephs GPII-442 branch

@gpii-bot
Copy link

CI job passed.

@kaspermarkus kaspermarkus requested a review from amb26 December 13, 2017 17:58
@amb26
Copy link
Member

amb26 commented Dec 14, 2017

Could we get this updated to master and the conflicts removed? @JavierJF will be looking at this together with his work improving the structure of acceptance tests

@gpii-bot
Copy link

CI job failed: https://ci.gpii.net/job/windows-tests/345/

@gpii-bot
Copy link

CI job failed: https://ci.gpii.net/job/windows-tests/346/

@kaspermarkus
Copy link
Member Author

Updated things on universal side, so:

ok to test

@gpii-bot
Copy link

CI job failed: https://ci.gpii.net/job/windows-tests/347/

@kaspermarkus
Copy link
Member Author

ok to test

@gpii-bot
Copy link

CI job failed: https://ci.gpii.net/job/windows-tests/349/

@gpii-bot
Copy link

gpii-bot commented Jan 3, 2018

CI job passed: https://ci.gpii.net/job/windows-tests/352/

@kaspermarkus
Copy link
Member Author

@amb26 With the help of Joseph's fix for GPII-2777 (which is actually a fix for GPII-2668 #156 ) and a bit of other changes, this is now finally passing



gpii.windows.enableRegisteredAT.queryProcessReporter = function (entry) {
return gpii.processReporter.find(entry.options.queryProcess);
Copy link
Member

@klown klown Jan 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be routed through gpii.processReporter.handleIsRunning(), where the reference to gpii.processReporter.find() is given via the entry argument. That is, entry.options.queryProcess should look like:

 "queryProcess": [
            {
                "type": "gpii.processReporter.find",
                "command": "Magnify.exe"
            }
  ]
...

The technique is to evaluate a list of criteria to determine if a solution is running, and to declare how to do that in a solution's entry.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Further to my comment above, see the "Special Cases" in the ProcessReporter README, specifically the third paragraph

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kaspermarkus - bump

@klown
Copy link
Member

klown commented Jan 29, 2018

Hey @kaspermarkus
I decided to try out what I was talking about above. It works, but there were a number of finicky details. Since I've done it, I decided to make your life easier by branching off your code here, and then making a pull request that you can use.

I'm checking a few things right now, but expect to see something in the next little while, including some associated changes to the universal code (i.e. two pull requests against your code).

@gpii-bot
Copy link

CI job failed: https://ci.gpii.net/job/windows-tests/390/

@amb26
Copy link
Member

amb26 commented Apr 3, 2018

Hi there @kaspermarkus - could you update this to current master of universal etc. and check that it is still ok?

@gpii-bot
Copy link

gpii-bot commented May 3, 2018

CI job passed: https://ci.gpii.net/job/windows-tests/479/

@amb26
Copy link
Member

amb26 commented May 4, 2018

Closed for #173

@amb26 amb26 closed this May 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants