-
Notifications
You must be signed in to change notification settings - Fork 39
GPII-1230, GPII-1235, GPII-442: Running application detection and support for more advanced MM #120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CI job passed. |
|
Could we get this updated to master and the conflicts removed? @JavierJF will be looking at this together with his work improving the structure of acceptance tests |
|
CI job failed: https://ci.gpii.net/job/windows-tests/345/ |
|
CI job failed: https://ci.gpii.net/job/windows-tests/346/ |
|
Updated things on universal side, so: ok to test |
|
CI job failed: https://ci.gpii.net/job/windows-tests/347/ |
|
ok to test |
|
CI job failed: https://ci.gpii.net/job/windows-tests/349/ |
|
CI job passed: https://ci.gpii.net/job/windows-tests/352/ |
|
|
||
|
|
||
| gpii.windows.enableRegisteredAT.queryProcessReporter = function (entry) { | ||
| return gpii.processReporter.find(entry.options.queryProcess); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be routed through gpii.processReporter.handleIsRunning(), where the reference to gpii.processReporter.find() is given via the entry argument. That is, entry.options.queryProcess should look like:
"queryProcess": [
{
"type": "gpii.processReporter.find",
"command": "Magnify.exe"
}
]
...
The technique is to evaluate a list of criteria to determine if a solution is running, and to declare how to do that in a solution's entry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Further to my comment above, see the "Special Cases" in the ProcessReporter README, specifically the third paragraph
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kaspermarkus - bump
|
Hey @kaspermarkus I'm checking a few things right now, but expect to see something in the next little while, including some associated changes to the universal code (i.e. two pull requests against your code). |
|
CI job failed: https://ci.gpii.net/job/windows-tests/390/ |
|
Hi there @kaspermarkus - could you update this to current master of universal etc. and check that it is still ok? |
|
CI job passed: https://ci.gpii.net/job/windows-tests/479/ |
|
Closed for #173 |
This branch is compatible with the advanced MM branch GPII-1230 of universal (GPII/universal#507). It contains the (relevant) code from Josephs GPII-442 branch