Skip to content

Conversation

@stegru
Copy link
Member

@stegru stegru commented Mar 7, 2018

This is the settings handler that lets you perform changes using the same back-end as the system settings applet (aka, immersive control panel).

The main piece of work is performed in an external helper C# program, because it has to be running as 64-bit. This is built during npm install (via provisioning/NpmInstall.ps1).

@gpii-bot
Copy link

gpii-bot commented Mar 7, 2018

CI job failed: https://ci.gpii.net/job/windows-tests/410/

@stegru
Copy link
Member Author

stegru commented Mar 7, 2018

default: WinRM transport: negotiate
Timed out while waiting for the machine to boot. This means that
Vagrant was unable to communicate with the guest machine within
the configured ("config.vm.boot_timeout" value) time period.

ok to test

@gpii-bot
Copy link

gpii-bot commented Mar 7, 2018

CI job failed: https://ci.gpii.net/job/windows-tests/411/

@stegru
Copy link
Member Author

stegru commented Mar 7, 2018

another CI related error

Fetching upstream changes from https://github.com/stegru/windows.git
 > git --version # timeout=10
 > git fetch --tags --progress https://github.com/stegru/windows.git +refs/heads/*:refs/remotes/origin/*
ERROR: Timeout after 10 minutes
ERROR: Error cloning remote repo 'origin'
hudson.plugins.git.GitException: Command "git fetch --tags --progress https://github.com/stegru/windows.git +refs/heads/*:refs/remotes/origin/*" returned status code 143

ok to test

@stegru
Copy link
Member Author

stegru commented Mar 8, 2018

ok to test

@gpii-bot
Copy link

gpii-bot commented Mar 8, 2018

CI job passed: https://ci.gpii.net/job/windows-tests/413/

@the-t-in-rtf
Copy link
Member

So, the changes to the package.json to run the build steps as part of npm install are a key improvement, but now Vagrant builds are running that step twice. Unless there is a key reason to do both, I'd suggest updating this line:

https://github.com/stegru/windows/blob/GPII-2772/Vagrantfile#L45

# Conflicts:
#	index.js
#	provisioning/Build.ps1
@stegru
Copy link
Member Author

stegru commented Mar 27, 2018

I've removed the bits of Build.ps1 that are called in npm install.

NpmInstall.ps1 gets calles from npm install, this generates the dependencies for gpii-windows (the test-window and helper executable that this PR is for).

@gpii-bot
Copy link

CI job passed: https://ci.gpii.net/job/windows-tests/433/

@gpii-bot
Copy link

CI job failed: https://ci.gpii.net/job/windows-tests/438/

@stegru
Copy link
Member Author

stegru commented Apr 3, 2018

ok to test

==> default: Destroying VM and associated drives...
/opt/vagrant/embedded/gems/gems/httpclient-2.8.3/lib/httpclient/session.rb:623:in `rescue in create_socket': Connection refused - Connection refused - connect(2) for "127.0.0.1" port 5985 (127.0.0.1:5985) (Errno::ECONNREFUSED)

@gpii-bot
Copy link

gpii-bot commented Apr 3, 2018

CI job passed: https://ci.gpii.net/job/windows-tests/446/

@gpii-bot
Copy link

CI job failed: https://ci.gpii.net/job/windows-tests/472/

@amb26
Copy link
Member

amb26 commented Apr 30, 2018

Ok oops, well at least we have learned clearly that it does not work. I've pinged @kaspermarkus to take a look at his Windows pull - in the meantime let's drop back to the previous release

@stegru
Copy link
Member Author

stegru commented Apr 30, 2018

I've updated the universal reference to use GPII/universal#594. It contains a preference set nyx which uses this settings handler.

@gpii-bot
Copy link

CI job failed: https://ci.gpii.net/job/windows-tests/473/

@gpii-bot
Copy link

CI job failed: https://ci.gpii.net/job/windows-tests/474/

@stegru
Copy link
Member Author

stegru commented Apr 30, 2018

Failures
 - python2 (exited 1) - python2 not installed. An error occurred during installation:
 The operation has timed out
VERBOSE: 'C:\ProgramData\chocolatey\bin\choco.exe' exited with 1

ok to test

@gpii-bot
Copy link

CI job failed: https://ci.gpii.net/job/windows-tests/475/

@gpii-bot
Copy link

CI job passed: https://ci.gpii.net/job/windows-tests/476/

@gpii-bot
Copy link

gpii-bot commented May 7, 2018

CI job passed: https://ci.gpii.net/job/windows-tests/482/

@stegru
Copy link
Member Author

stegru commented May 23, 2018

ok to test (big update to universal)

@gpii-bot
Copy link

CI job passed: https://ci.gpii.net/job/windows-tests/495/

@gpii-bot
Copy link

CI job passed: https://ci.gpii.net/job/windows-tests/543/

package.json Outdated
"edge-js": "8.8.1",
"ffi": "2.0.0",
"gpii-universal": "0.3.0-dev.20180608T130946Z.7218a34",
"gpii-universal": "stegru/universal#GPII-2717",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you meant this to be bound to your branch #GPII-2772 which is the matching one from GPII/universal#594 - GPII-2717 looks to be a very stale branch

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no wonder the test passed!

@gpii-bot
Copy link

CI job failed: https://ci.gpii.net/job/windows-tests/557/

@amb26
Copy link
Member

amb26 commented Jun 25, 2018

Pretty weird integrity failure:

default: npm ERR! code EINTEGRITY
    default: npm ERR! sha1-0Ng2s0OqbbiMDez+rnHmJ11BQg4= integrity checksum failed when using sha1: wanted sha1-0Ng2s0OqbbiMDez+rnHmJ11BQg4= but got sha1-kZpOsrsMqUlqMV9U2uFSFQ36qa0=. (7551734 bytes)

npm's shoddy error reporting doesn't make it clear which package. But a big one ....

@amb26
Copy link
Member

amb26 commented Jun 25, 2018

ok to test

@gpii-bot
Copy link

CI job failed: https://ci.gpii.net/job/windows-tests/558/

@amb26 amb26 merged commit e2a4944 into GPII:master Jun 25, 2018
@amb26
Copy link
Member

amb26 commented Jun 27, 2018

Proper failure this time, pretty worrying. It may be random, given I did verify that this worked locally:

09:03:26.245:  jq: Expected: {
    "gpii.windows.enableRegisteredAT": {
        "com.microsoft.windows.magnifier": [
            {
                "settings": {
                    "running": true
                }
            }
        ],
        "com.microsoft.windows.onscreenKeyboard": [
            {
                "settings": {
                    "running": true
                }
            }
        ]
    }
}
09:03:26.249:  jq: Actual: {
    "gpii.windows.enableRegisteredAT": {
        "com.microsoft.windows.magnifier": [
            {
                "settings": {
                    "running": true
                }
            }
        ],
        "com.microsoft.windows.onscreenKeyboard": [
            {
                "settings": {
                    "running": false
                }
            }
        ]
    }
}

@amb26
Copy link
Member

amb26 commented Jun 27, 2018

ok to test

@stegru
Copy link
Member Author

stegru commented Jun 27, 2018

enabledRegisteredAT doesn't start the AT process directly, but via the shell (to start a 64-bit process) so there's a race between the real process starting, and the processReporter call. enabledRegisteredAT does return a promise for this, but it's not being passed back in the launch handler.

gpii.windows.enableRegisteredAT(registryName, enable, entry.options);

@amb26
Copy link
Member

amb26 commented Jun 27, 2018

Terrible!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants