-
Notifications
You must be signed in to change notification settings - Fork 39
GPII-2772: Windows system settings handler #167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
# Conflicts: # index.js # package.json
|
CI job failed: https://ci.gpii.net/job/windows-tests/410/ |
ok to test |
|
CI job failed: https://ci.gpii.net/job/windows-tests/411/ |
|
another CI related error ok to test |
|
ok to test |
|
CI job passed: https://ci.gpii.net/job/windows-tests/413/ |
|
So, the changes to the https://github.com/stegru/windows/blob/GPII-2772/Vagrantfile#L45 |
# Conflicts: # index.js # provisioning/Build.ps1
|
I've removed the bits of
|
|
CI job passed: https://ci.gpii.net/job/windows-tests/433/ |
|
CI job failed: https://ci.gpii.net/job/windows-tests/438/ |
|
ok to test |
|
CI job passed: https://ci.gpii.net/job/windows-tests/446/ |
|
CI job failed: https://ci.gpii.net/job/windows-tests/472/ |
|
Ok oops, well at least we have learned clearly that it does not work. I've pinged @kaspermarkus to take a look at his Windows pull - in the meantime let's drop back to the previous release |
|
I've updated the universal reference to use GPII/universal#594. It contains a preference set |
|
CI job failed: https://ci.gpii.net/job/windows-tests/473/ |
|
CI job failed: https://ci.gpii.net/job/windows-tests/474/ |
ok to test |
|
CI job failed: https://ci.gpii.net/job/windows-tests/475/ |
|
CI job passed: https://ci.gpii.net/job/windows-tests/476/ |
# Conflicts: # package.json
|
CI job passed: https://ci.gpii.net/job/windows-tests/482/ |
|
ok to test (big update to universal) |
|
CI job passed: https://ci.gpii.net/job/windows-tests/495/ |
# Conflicts: # package.json
|
CI job passed: https://ci.gpii.net/job/windows-tests/543/ |
package.json
Outdated
| "edge-js": "8.8.1", | ||
| "ffi": "2.0.0", | ||
| "gpii-universal": "0.3.0-dev.20180608T130946Z.7218a34", | ||
| "gpii-universal": "stegru/universal#GPII-2717", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume you meant this to be bound to your branch #GPII-2772 which is the matching one from GPII/universal#594 - GPII-2717 looks to be a very stale branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no wonder the test passed!
|
CI job failed: https://ci.gpii.net/job/windows-tests/557/ |
|
Pretty weird integrity failure: npm's shoddy error reporting doesn't make it clear which package. But a big one .... |
|
ok to test |
|
CI job failed: https://ci.gpii.net/job/windows-tests/558/ |
|
Proper failure this time, pretty worrying. It may be random, given I did verify that this worked locally: |
|
ok to test |
|
|
|
Terrible! |
This is the settings handler that lets you perform changes using the same back-end as the system settings applet (aka, immersive control panel).
The main piece of work is performed in an external helper C# program, because it has to be running as 64-bit. This is built during
npm install(via provisioning/NpmInstall.ps1).